From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: David Gibson <david@gibson.dropbear.id.au>, alex.williamson@redhat.com
Cc: qemu-ppc@nongnu.org, agraf@suse.de, gwshan@au1.ibm.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks
Date: Mon, 29 Feb 2016 18:28:02 +1100 [thread overview]
Message-ID: <56D3F302.2050308@ozlabs.ru> (raw)
In-Reply-To: <1456729587-17229-4-git-send-email-david@gibson.dropbear.id.au>
On 02/29/2016 06:06 PM, David Gibson wrote:
> The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the
> special groupid field in sPAPRPHBVFIOState. So we can simplify, removing
> the class specific callbacks with direct calls based on a simple
> spapr_phb_eeh_enabled() helper. For now we implement that in terms of
> a boolean in the class, but we'll continue to clean that up later.
>
> On its own this is a rather strange way of doing things, but it's a useful
> intermediate step to further cleanups.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
--
Alexey
next prev parent reply other threads:[~2016-02-29 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 7:06 [Qemu-devel] [PATCHv2 0/7] Allow EEH on spapr-pci-host-bridge devices David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 1/7] vfio: Start improving VFIO/EEH interface David Gibson
2016-02-29 7:27 ` Alexey Kardashevskiy
2016-03-07 19:49 ` Alex Williamson
2016-03-08 1:34 ` David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 2/7] spapr_pci: Switch to vfio_eeh_as_op() interface David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks David Gibson
2016-02-29 7:28 ` Alexey Kardashevskiy [this message]
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 4/7] spapr_pci: Allow EEH on spapr-pci-host-bridge David Gibson
2016-02-29 7:28 ` Alexey Kardashevskiy
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 5/7] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge David Gibson
2016-02-29 7:28 ` Alexey Kardashevskiy
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 6/7] spapr_pci: Remove finish_realize hook David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 7/7] vfio: Eliminate vfio_container_ioctl() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D3F302.2050308@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=gwshan@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.