From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaIFk-00046f-PL for qemu-devel@nongnu.org; Mon, 29 Feb 2016 02:28:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaIFg-0003l6-M2 for qemu-devel@nongnu.org; Mon, 29 Feb 2016 02:28:24 -0500 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]:35941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaIFg-0003kt-Ey for qemu-devel@nongnu.org; Mon, 29 Feb 2016 02:28:20 -0500 Received: by mail-pa0-x22d.google.com with SMTP id yy13so87399588pab.3 for ; Sun, 28 Feb 2016 23:28:20 -0800 (PST) References: <1456729587-17229-1-git-send-email-david@gibson.dropbear.id.au> <1456729587-17229-5-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <56D3F30C.5020000@ozlabs.ru> Date: Mon, 29 Feb 2016 18:28:12 +1100 MIME-Version: 1.0 In-Reply-To: <1456729587-17229-5-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 4/7] spapr_pci: Allow EEH on spapr-pci-host-bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , alex.williamson@redhat.com Cc: qemu-ppc@nongnu.org, agraf@suse.de, gwshan@au1.ibm.com, qemu-devel@nongnu.org On 02/29/2016 06:06 PM, David Gibson wrote: > Now that the EEH code is independent of the special > spapr-vfio-pci-host-bridge device, we can allow it on all spapr PCI > host bridges instead. We do this by changing spapr_phb_eeh_available() > to be based on the vfio_eeh_as_ok() call instead of the host bridge class. > > Because the value of vfio_eeh_as_ok() can change with devices being > hotplugged or unplugged, this can potentially lead to some strange edge > cases where the guest starts using EEH, then it starts failing because > of a change in status. > > However, it's not really any worse than the current situation. Cases that > would have worked previously will still work (i.e. VFIO devices from at > most one VFIO IOMMU group per vPHB), it's just that it's no longer > necessary to use spapr-vfio-pci-host-bridge with the groupid pre-specified. > > Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy -- Alexey