From: Lokesh Vutla <a0131933@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] am33xx: Update serial platdata to update reg_offset to 0
Date: Mon, 29 Feb 2016 15:03:14 +0530 [thread overview]
Message-ID: <56D4105A.3090604@ti.com> (raw)
In-Reply-To: <1456737957-25168-1-git-send-email-mugunthanvnm@ti.com>
On Monday 29 February 2016 02:55 PM, Mugunthan V N wrote:
> With commit: d9a3bec682f9 "dm: ns16550: Add support for reg-offset property"
> reg_offset is added to the struct ns16550_platdata to be
> dt compatible with Linux kernel driver, TI AM335x evms are broken
> as the serial platdata updates wrong offsets. Correcting it with
> initializing reg_offset to zero.
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
This will be true for OMAP5+ platforms as well. I guess that array also
needs to be updated?
Thanks and regards,
Lokesh
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
>
> Verified the patch on AM335x BBB ad AM335x EVMsk.
>
> ---
> arch/arm/cpu/armv7/am33xx/board.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c
> index e8d5be3..2963b3b 100644
> --- a/arch/arm/cpu/armv7/am33xx/board.c
> +++ b/arch/arm/cpu/armv7/am33xx/board.c
> @@ -40,14 +40,14 @@ DECLARE_GLOBAL_DATA_PTR;
>
> #if !CONFIG_IS_ENABLED(OF_CONTROL)
> static const struct ns16550_platdata am33xx_serial[] = {
> - { CONFIG_SYS_NS16550_COM1, 2, CONFIG_SYS_NS16550_CLK },
> + { CONFIG_SYS_NS16550_COM1, 0, 2, CONFIG_SYS_NS16550_CLK },
> # ifdef CONFIG_SYS_NS16550_COM2
> - { CONFIG_SYS_NS16550_COM2, 2, CONFIG_SYS_NS16550_CLK },
> + { CONFIG_SYS_NS16550_COM2, 0, 2, CONFIG_SYS_NS16550_CLK },
> # ifdef CONFIG_SYS_NS16550_COM3
> - { CONFIG_SYS_NS16550_COM3, 2, CONFIG_SYS_NS16550_CLK },
> - { CONFIG_SYS_NS16550_COM4, 2, CONFIG_SYS_NS16550_CLK },
> - { CONFIG_SYS_NS16550_COM5, 2, CONFIG_SYS_NS16550_CLK },
> - { CONFIG_SYS_NS16550_COM6, 2, CONFIG_SYS_NS16550_CLK },
> + { CONFIG_SYS_NS16550_COM3, 0, 2, CONFIG_SYS_NS16550_CLK },
> + { CONFIG_SYS_NS16550_COM4, 0, 2, CONFIG_SYS_NS16550_CLK },
> + { CONFIG_SYS_NS16550_COM5, 0, 2, CONFIG_SYS_NS16550_CLK },
> + { CONFIG_SYS_NS16550_COM6, 0, 2, CONFIG_SYS_NS16550_CLK },
> # endif
> # endif
> };
>
next prev parent reply other threads:[~2016-02-29 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 9:25 [U-Boot] [PATCH 1/1] am33xx: Update serial platdata to update reg_offset to 0 Mugunthan V N
2016-02-29 9:33 ` Lokesh Vutla [this message]
2016-03-01 5:55 ` Mugunthan V N
2016-03-02 11:09 ` Adam Ford
2016-03-02 11:53 ` Michal Simek
2016-03-02 12:18 ` Adam Ford
2016-03-02 12:24 ` Michal Simek
2016-03-02 12:55 ` Adam Ford
2016-03-03 4:49 ` Mugunthan V N
2016-03-08 3:23 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4105A.3090604@ti.com \
--to=a0131933@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.