All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Martin Galvan <martin.galvan@tallertechnologies.com>,
	qemu-devel@nongnu.org, peter.maydell@linaro.org,
	aurelio.remonda@tallertechnologies.com,
	daniel.gutson@tallertechnologies.com
Subject: Re: [Qemu-devel] [PING][PATCH] Use unsigned types for the 'len' argument of all memory read/write functions
Date: Mon, 29 Feb 2016 15:59:00 +0100	[thread overview]
Message-ID: <56D45CB4.1080600@redhat.com> (raw)
In-Reply-To: <1456749628-2776-1-git-send-email-martin.galvan@tallertechnologies.com>



On 29/02/2016 13:40, Martin Galvan wrote:
> When looking at address_space_read_continue I noticed the 'len' variable was
> a signed int, while it clearly should be a hwaddr or some other unsigned type.
> I started looking around and saw that this error had spread all over the code.
> 
> I replaced the signed int by their unsigned counterparts as much as possible.
> If this patch goes in, I may keep working on some other type errors I saw.
> 
> Signed-off-by: Martin Galvan <martin.galvan@tallertechnologies.com>

Hi Martin,

despite the apparent simplicity, this patch is very hard to review.  I
suggest splitting it in several parts so that the various submaintainers
can look at it.  I can take a look at cpus.c, exec.c, kvm-all.c and
include/exec/, for example.

Please use size_t instead of hwaddr to refer to the size of a buffer in
host memory, for example address_space_rw's buf argument.

Thanks,

Paolo

  reply	other threads:[~2016-02-29 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 12:40 [Qemu-devel] [PING][PATCH] Use unsigned types for the 'len' argument of all memory read/write functions Martin Galvan
2016-02-29 14:59 ` Paolo Bonzini [this message]
2016-02-29 15:28   ` Martin Galvan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D45CB4.1080600@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aurelio.remonda@tallertechnologies.com \
    --cc=daniel.gutson@tallertechnologies.com \
    --cc=martin.galvan@tallertechnologies.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.