From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH 2/5] dbus: Coalesce PropertiesChanged signals
Date: Mon, 29 Feb 2016 15:26:44 -0600 [thread overview]
Message-ID: <56D4B794.8030105@gmail.com> (raw)
In-Reply-To: <CAOq732+Ai=m+BVD6xxhip+CezQ8Um8rR5ehkAQVw-=US6bf+Aw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
After talking to Andrew, I realized I was off-base here.
>> This looks a bit suspicious. Should we be also comparing the object
>> pointer, not just the instance pointer here?
>
> Assuming that only one object can have the instance it shouldn't
> matter. When the object or the instance are removed, the property
> change record is also removed so it won't accidentally point at a
> different instance.
I for some reason was thinking we're tracking l_dbus_interface objects,
not interface_instance. So after being being reminded of that, the code
is just fine.
Regards,
-Denis
next prev parent reply other threads:[~2016-02-29 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 3:20 [PATCH 1/5] dbus: Coalesce InterfacesAdded/Removed signals Andrew Zaborowski
2016-02-18 3:20 ` [PATCH 2/5] dbus: Coalesce PropertiesChanged signals Andrew Zaborowski
2016-02-26 20:30 ` Denis Kenzior
2016-02-29 9:21 ` Andrzej Zaborowski
2016-02-29 15:43 ` Denis Kenzior
2016-02-29 21:26 ` Denis Kenzior [this message]
2016-02-18 3:20 ` [PATCH 3/5] dbus: Move standard interface name defines to public header Andrew Zaborowski
2016-02-18 3:20 ` [PATCH 4/5] examples: dbus-service: Use interface name macros Andrew Zaborowski
2016-02-18 3:20 ` [PATCH 5/5] unit: Update PropertyChanged value check Andrew Zaborowski
2016-02-26 20:27 ` [PATCH 1/5] dbus: Coalesce InterfacesAdded/Removed signals Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4B794.8030105@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.