From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH] dt-bindings: gpio: altera: Fix altr,interrupt-type property Date: Tue, 01 Mar 2016 02:29:59 +0100 Message-ID: <56D4F097.3000105@denx.de> References: <1456762997-7607-1-git-send-email-marex@denx.de> <56D4EEE9.3060308@electromag.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-out.m-online.net ([212.18.0.9]:42687 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbcCABaD (ORCPT ); Mon, 29 Feb 2016 20:30:03 -0500 In-Reply-To: <56D4EEE9.3060308@electromag.com.au> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Phil Reid , linux-gpio@vger.kernel.org Cc: Tien Hock Loh , Linus Walleij On 03/01/2016 02:22 AM, Phil Reid wrote: > On 1/03/2016 12:23 AM, Marek Vasut wrote: >> The altr,interrupt-trigger property is not used by the driver. >> Instead, altr,interrupt-type is used by the driver and the driver >> does not probe if this property is not specified. Therefore, it >> is expected that there are no users of the -trigger property in >> the wild and that this is a typo in the documentation for the >> altera-pio controller. This patch fixes the typo. >> > > On a related note. The Altera QSYS 15.0 device tree tools generate this > label this as altr,interrupt_type Aaaaaaargh :-( > Note: '_' instead of '-'. > I've locally patch the driver to look for both names. > Not sure if this is something that should be fixed in the driver or > require user to to post process the generated dts. > > I haven't reported the issue to Altera either. It's the tools which should be fixed in this case. Since mainline does not mention this binding with '_' anywhere, it's not part of ABI and I would really go for fixing the tools in this case. Thanks for the report! -- Best regards, Marek Vasut