From: "Christian König" <christian.koenig@amd.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Gustavo Padovan <gustavo@padovan.org>,
Alex Deucher <alexdeucher@gmail.com>,
dri-devel@lists.freedesktop.org, sumit.semwal@linaro.org,
linaro-mm-sig@lists.linaro.org,
Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] dma-buf/fence: fix fence_is_later v2
Date: Tue, 1 Mar 2016 09:42:01 +0100 [thread overview]
Message-ID: <56D555D9.4040804@amd.com> (raw)
In-Reply-To: <56D5549A.6030005@linux.intel.com>
Am 01.03.2016 um 09:36 schrieb Maarten Lankhorst:
> Op 29-02-16 om 23:13 schreef Gustavo Padovan:
>> 2016-02-29 Alex Deucher <alexdeucher@gmail.com>:
>>
>>> From: Christian König <christian.koenig@amd.com>
>>>
>>> A fence is never later than itself. This caused a bunch of overhead for AMDGPU.
>>>
>>> v2: simplify check as suggested by Michel.
>>>
>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
>>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>>> ---
>>> include/linux/fence.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>
>> Gustavo
> Why is it causing overhead? Not really opposed to the patch though.
We tested if flushing the VM is necessary by remembering the last
flushed VM update operation and comparing that to what operation we need
to have flushed for the current command submission to work.
So when we where already at the last operation in the timeline we would
flush anyway which was superfluous.
Regards,
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-01 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 15:53 [PATCH] dma-buf/fence: fix fence_is_later v2 Alex Deucher
2016-02-29 22:13 ` Gustavo Padovan
2016-03-01 8:36 ` Maarten Lankhorst
2016-03-01 8:42 ` Christian König [this message]
2016-03-03 12:43 ` Sumit Semwal
-- strict thread matches above, loose matches on Subject: below --
2016-02-23 2:21 Alex Deucher
2016-02-22 19:32 Alex Deucher
2016-02-23 2:04 ` Michel Dänzer
2016-02-29 15:48 ` Daniel Vetter
2016-03-02 3:02 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D555D9.4040804@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.