From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH v3] af_packet: make the device detachable Date: Tue, 1 Mar 2016 11:43:57 +0200 Message-ID: <56D5645D.3050304@redhat.com> References: <1455208630-21710-1-git-send-email-woz@semihalf.com> <8CEF83825BEC744B83065625E567D7C219FB4223@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: =?UTF-8?Q?Wojciech_=c5=bbmuda?= , "Iremonger, Bernard" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3E3559AB5 for ; Tue, 1 Mar 2016 10:44:00 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/29/2016 08:22 PM, Wojciech =C5=BBmuda wrote: > Hi Bernard, > >> Does making rte_pmd_af_packet_devinit local result in an ABI breakag= e? > If someone uses it in their app, they'll be forced to change it. > However, as this function is not intentionally public and there is API > to create devices that finally calls rte_pmd_af_packet_devinit(), I'm > not sure if any special caution is needed here. Yeah this is a bit of a gray area. Strictly speaking it certainly is an=20 ABI break, but given that the function is documented as internal-only=20 and there's a proper, public way to create the device, there's no good=20 excuse for anybody to be using it. I think its okay to remove without=20 going through the deprecation process. > >> Should the DPDK_2.0 structure be kept and a DPDK_2.3 structure added? > Should it be just `DPDK_2.3 { local: *} DPDK_2.0`? Doesn't inheritance > of DPDK_2.0 make the symbol also global in 2.3? Since there are no symbols being exported I dont see any point in=20 changing the version, just drop the accidentally exported symbol from=20 the 2.0 definition. - Panu - >> A deprecation notice may need to be added to the doc/guides/rel_notes/= deprecation.rst file. > As far as I understand, deprecation.rst is used to announce something > will be removed in the future release. Changes already done should be > moved from deprecation.rst to the release's .rst file. At least, this > is what I see in commit logs. If this change should be announced in > deprecation.rst, does this mean there should be another patch in the > future (after 2.3 release?) making this function static? And that > future patch will add DPDK_2.3 structure in the map file? > > Thank you for your time, > Wojtek >