From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node Date: Tue, 1 Mar 2016 10:48:05 +0100 Message-ID: <56D56555.1030703@atmel.com> References: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from eusmtp01.atmel.com ([212.144.249.242]:14090 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcCAJr4 (ORCPT ); Tue, 1 Mar 2016 04:47:56 -0500 In-Reply-To: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Romain Izard , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: Alexandre Belloni , Linus Walleij , Linux GPIO List Le 18/02/2016 11:21, Romain Izard a =C3=A9crit : > All pinctrl nodes for the Atmel pinctrl controller need to have their > bias configuration explicitly defined. Otherwise, the pinctrl mapping > is not valid. >=20 > It works for now as the pinctrl driver proceeds even with invalid > mappings, but this can become an issue, if the pinctrl driver starts > to require valid mappings. Additionally, the pin is not protected fro= m > being remapped later by an other driver. >=20 > There is an external 1k=E2=84=A6 pull-up to 3.3V, so no bias is requi= red on > the Ethernet PHY's interrupt line. >=20 > Signed-off-by: Romain Izard Acked-by: Nicolas Ferre And queued on at91-4.5-dt. Thanks! Bye, > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/b= oot/dts/at91-sama5d2_xplained.dts > index e683856c507c..75341eec2dfd 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -308,6 +308,7 @@ > =20 > pinctrl_macb0_phy_irq: macb0_phy_irq { > pinmux =3D ; > + bias-disable; > }; > =20 > pinctrl_pdmic_default: pdmic_default { >=20 --=20 Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 1 Mar 2016 10:48:05 +0100 Subject: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node In-Reply-To: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> References: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> Message-ID: <56D56555.1030703@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 18/02/2016 11:21, Romain Izard a ?crit : > All pinctrl nodes for the Atmel pinctrl controller need to have their > bias configuration explicitly defined. Otherwise, the pinctrl mapping > is not valid. > > It works for now as the pinctrl driver proceeds even with invalid > mappings, but this can become an issue, if the pinctrl driver starts > to require valid mappings. Additionally, the pin is not protected from > being remapped later by an other driver. > > There is an external 1k? pull-up to 3.3V, so no bias is required on > the Ethernet PHY's interrupt line. > > Signed-off-by: Romain Izard Acked-by: Nicolas Ferre And queued on at91-4.5-dt. Thanks! Bye, > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > index e683856c507c..75341eec2dfd 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -308,6 +308,7 @@ > > pinctrl_macb0_phy_irq: macb0_phy_irq { > pinmux = ; > + bias-disable; > }; > > pinctrl_pdmic_default: pdmic_default { > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbcCAJr6 (ORCPT ); Tue, 1 Mar 2016 04:47:58 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:14090 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcCAJr4 (ORCPT ); Tue, 1 Mar 2016 04:47:56 -0500 Subject: Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node To: Romain Izard , , , References: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> CC: Alexandre Belloni , Linus Walleij , Linux GPIO List From: Nicolas Ferre Organization: atmel Message-ID: <56D56555.1030703@atmel.com> Date: Tue, 1 Mar 2016 10:48:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/02/2016 11:21, Romain Izard a écrit : > All pinctrl nodes for the Atmel pinctrl controller need to have their > bias configuration explicitly defined. Otherwise, the pinctrl mapping > is not valid. > > It works for now as the pinctrl driver proceeds even with invalid > mappings, but this can become an issue, if the pinctrl driver starts > to require valid mappings. Additionally, the pin is not protected from > being remapped later by an other driver. > > There is an external 1kΩ pull-up to 3.3V, so no bias is required on > the Ethernet PHY's interrupt line. > > Signed-off-by: Romain Izard Acked-by: Nicolas Ferre And queued on at91-4.5-dt. Thanks! Bye, > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > index e683856c507c..75341eec2dfd 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -308,6 +308,7 @@ > > pinctrl_macb0_phy_irq: macb0_phy_irq { > pinmux = ; > + bias-disable; > }; > > pinctrl_pdmic_default: pdmic_default { > -- Nicolas Ferre