From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH 4/4] x86: fix printf format warnings Date: Tue, 1 Mar 2016 11:52:04 +0100 Message-ID: <56D57454.3080504@redhat.com> References: <1456777155-8599-1-git-send-email-drjones@redhat.com> <1456777155-8599-5-git-send-email-drjones@redhat.com> <56D528F6.6050503@redhat.com> <20160301092448.dj42i7cvtmgtpumz@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, rkrcmar@redhat.com To: Andrew Jones , Thomas Huth Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47649 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752460AbcCAKwI (ORCPT ); Tue, 1 Mar 2016 05:52:08 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2447E7F0A0 for ; Tue, 1 Mar 2016 10:52:08 +0000 (UTC) In-Reply-To: <20160301092448.dj42i7cvtmgtpumz@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 01/03/2016 10:24, Andrew Jones wrote: >> > So either the lower part has explicitely be casted to (uint32_t), or >> > simply print the whole value only once with llx, without the colon >> > inbetween. > Uff, I guess I was in monkey mode at this point. I'll change it to the > last suggestion, no ':'. There are cases where the result is split in two 32-bit values (e.g. IA32_VMX_PROCBASED_CTLS) so the ":" is nice to have. Paolo