All of lore.kernel.org
 help / color / mirror / Atom feed
From: andre.przywara@arm.com (Andre Przywara)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node
Date: Tue, 1 Mar 2016 11:01:07 +0000	[thread overview]
Message-ID: <56D57673.8030702@arm.com> (raw)
In-Reply-To: <1456789465-2962-8-git-send-email-afaerber@suse.de>

Hi Andreas,

On 29/02/16 23:44, Andreas F?rber wrote:
> Add GICH and GICV resources for HYP mode - guess based on other vendors.

Do you know if the firmware allows the kernel to be entered in EL2
(which is the arm64 name for HYP)?
So can we run kvm?
If you have a booted kernel, can you grep for "EL2" and "kvm" in the dmesg?

Also you should merge this patch into 3/8, same for 8/8.

> Signed-off-by: Andreas F?rber <afaerber@suse.de>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 0ae089bd1806..5088ae3ff653 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -117,7 +117,9 @@
>  		gic: interrupt-controller at c4301000 {
>  			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";

I think "arm,gic-400" is the name to use here these days, especially for
arm64.

>  			reg = <0x0 0xc4301000 0 0x1000>,
> -			      <0x0 0xc4302000 0 0x0100>;
> +			      <0x0 0xc4302000 0 0x0100>,

Please use 0x2000 for the size here. I guess this is really the GIC-400
from ARM, and in this case this is the right size, [1] is the reference
here. This will enable EOI mode 1 for KVM.

Cheers,
Andre.

[1]
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html

> +			      <0x0 0xc4304000 0 0x2000>,
> +			      <0x0 0xc4306000 0 0x2000>;
>  			interrupt-controller;
>  			interrupts = <GIC_PPI 9
>  				(GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
To: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>,
	linux-meson-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Matthias Brugger <mbrugger-IBi9RG/b67k@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Nicolas Saenz
	<nicolassaenzj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node
Date: Tue, 1 Mar 2016 11:01:07 +0000	[thread overview]
Message-ID: <56D57673.8030702@arm.com> (raw)
In-Reply-To: <1456789465-2962-8-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>

Hi Andreas,

On 29/02/16 23:44, Andreas Färber wrote:
> Add GICH and GICV resources for HYP mode - guess based on other vendors.

Do you know if the firmware allows the kernel to be entered in EL2
(which is the arm64 name for HYP)?
So can we run kvm?
If you have a booted kernel, can you grep for "EL2" and "kvm" in the dmesg?

Also you should merge this patch into 3/8, same for 8/8.

> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 0ae089bd1806..5088ae3ff653 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -117,7 +117,9 @@
>  		gic: interrupt-controller@c4301000 {
>  			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";

I think "arm,gic-400" is the name to use here these days, especially for
arm64.

>  			reg = <0x0 0xc4301000 0 0x1000>,
> -			      <0x0 0xc4302000 0 0x0100>;
> +			      <0x0 0xc4302000 0 0x0100>,

Please use 0x2000 for the size here. I guess this is really the GIC-400
from ARM, and in this case this is the right size, [1] is the reference
here. This will enable EOI mode 1 for KVM.

Cheers,
Andre.

[1]
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html

> +			      <0x0 0xc4304000 0 0x2000>,
> +			      <0x0 0xc4306000 0 0x2000>;
>  			interrupt-controller;
>  			interrupts = <GIC_PPI 9
>  				(GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: "Andreas Färber" <afaerber@suse.de>, linux-meson@googlegroups.com
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Matthias Brugger <mbrugger@suse.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Nicolas Saenz <nicolassaenzj@gmail.com>,
	Will Deacon <will.deacon@arm.com>,
	open list <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Carlo Caione <carlo@caione.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node
Date: Tue, 1 Mar 2016 11:01:07 +0000	[thread overview]
Message-ID: <56D57673.8030702@arm.com> (raw)
In-Reply-To: <1456789465-2962-8-git-send-email-afaerber@suse.de>

Hi Andreas,

On 29/02/16 23:44, Andreas Färber wrote:
> Add GICH and GICV resources for HYP mode - guess based on other vendors.

Do you know if the firmware allows the kernel to be entered in EL2
(which is the arm64 name for HYP)?
So can we run kvm?
If you have a booted kernel, can you grep for "EL2" and "kvm" in the dmesg?

Also you should merge this patch into 3/8, same for 8/8.

> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 0ae089bd1806..5088ae3ff653 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -117,7 +117,9 @@
>  		gic: interrupt-controller@c4301000 {
>  			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";

I think "arm,gic-400" is the name to use here these days, especially for
arm64.

>  			reg = <0x0 0xc4301000 0 0x1000>,
> -			      <0x0 0xc4302000 0 0x0100>;
> +			      <0x0 0xc4302000 0 0x0100>,

Please use 0x2000 for the size here. I guess this is really the GIC-400
from ARM, and in this case this is the right size, [1] is the reference
here. This will enable EOI mode 1 for KVM.

Cheers,
Andre.

[1]
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html

> +			      <0x0 0xc4304000 0 0x2000>,
> +			      <0x0 0xc4306000 0 0x2000>;
>  			interrupt-controller;
>  			interrupts = <GIC_PPI 9
>  				(GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> 

  reply	other threads:[~2016-03-01 11:01 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 23:44 [PATCH 0/8] ARM64: meson: GXBaby (S905) and Vega S95 enablement Andreas Färber
2016-02-29 23:44 ` Andreas Färber
2016-02-29 23:44 ` [PATCH 1/8] ARM64: Enable Amlogic Meson GXBaby platform Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-03-01 14:43   ` Sudeep Holla
2016-03-01 14:43     ` Sudeep Holla
2016-03-01 15:26     ` Andreas Färber
2016-03-01 15:26       ` Andreas Färber
2016-03-01 16:07       ` Sudeep Holla
2016-03-01 16:07         ` Sudeep Holla
2016-02-29 23:44 ` [PATCH 2/8] Documentation: devicetree: amlogic: Document Meson GXBaby Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44 ` [PATCH 3/8] ARM64: dts: Prepare configs for Amlogic " Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-03-01 14:43   ` Sudeep Holla
2016-03-01 14:43     ` Sudeep Holla
2016-03-01 14:43     ` Sudeep Holla
2016-03-01 15:18     ` Andreas Färber
2016-03-01 15:18       ` Andreas Färber
2016-03-01 15:18       ` Andreas Färber
2016-03-01 16:19       ` Sudeep Holla
2016-03-01 16:19         ` Sudeep Holla
2016-03-01 16:19         ` Sudeep Holla
2016-02-29 23:44 ` [PATCH 4/8] Documentation: devicetree: Document Tronsmart vendor prefix Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-03-01 11:37   ` Matthias Brugger
2016-03-01 11:37     ` Matthias Brugger
2016-03-01 11:37     ` Matthias Brugger
2016-03-01 11:53     ` Andreas Färber
2016-03-01 11:53       ` Andreas Färber
2016-03-01 11:53       ` Andreas Färber
2016-03-01 13:29       ` Matthias Brugger
2016-03-01 13:29         ` Matthias Brugger
2016-03-01 13:29         ` Matthias Brugger
2016-03-01 19:23       ` Beniamino Galvani
2016-03-01 19:23         ` Beniamino Galvani
2016-03-01 19:23         ` Beniamino Galvani
2016-03-03 23:57   ` Rob Herring
2016-03-03 23:57     ` Rob Herring
2016-02-29 23:44 ` [PATCH 5/8] Documentation: devicetree: amlogic: Document Tronsmart Vega S95 boards Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44 ` [PATCH 6/8] ARM64: dts: amlogic: Add Tronsmart Vega S95 configs Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:55   ` Andreas Färber
2016-02-29 23:55     ` Andreas Färber
2016-02-29 23:55     ` Andreas Färber
2016-02-29 23:44 ` [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-03-01 11:01   ` Andre Przywara [this message]
2016-03-01 11:01     ` Andre Przywara
2016-03-01 11:01     ` Andre Przywara
2016-03-01 11:18     ` Andreas Färber
2016-03-01 11:18       ` Andreas Färber
2016-03-01 11:18       ` Andreas Färber
2016-03-01 11:42       ` Matthias Brugger
2016-03-01 11:42         ` Matthias Brugger
2016-03-01 11:42         ` Matthias Brugger
2016-03-01 12:43       ` Andre Przywara
2016-03-01 12:43         ` Andre Przywara
2016-03-01 12:43         ` Andre Przywara
2016-03-01 12:53         ` Carlo Caione
2016-03-01 12:53           ` Carlo Caione
2016-03-01 12:53           ` Carlo Caione
2016-03-01 14:16           ` Andre Przywara
2016-03-01 14:16             ` Andre Przywara
2016-03-01 14:16             ` Andre Przywara
2016-03-01 22:46         ` Andreas Färber
2016-03-01 22:46           ` Andreas Färber
2016-03-01 22:58           ` André Przywara
2016-03-01 22:58             ` André Przywara
2016-03-01 22:58             ` André Przywara
2016-03-01 23:31         ` Andreas Färber
2016-03-01 23:31           ` Andreas Färber
2016-03-01 23:31           ` Andreas Färber
2016-03-02  0:03           ` André Przywara
2016-03-02  0:03             ` André Przywara
2016-03-02  0:07             ` Andreas Färber
2016-03-02  0:07               ` Andreas Färber
2016-02-29 23:44 ` [PATCH 8/8] ARM64: dts: amlogic: Add arch timer node for Meson GXBaby Andreas Färber
2016-02-29 23:44   ` Andreas Färber
2016-02-29 23:44   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D57673.8030702@arm.com \
    --to=andre.przywara@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.