From mboxrd@z Thu Jan 1 00:00:00 1970 From: andre.przywara@arm.com (Andre Przywara) Date: Tue, 1 Mar 2016 11:01:07 +0000 Subject: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node In-Reply-To: <1456789465-2962-8-git-send-email-afaerber@suse.de> References: <1456789465-2962-1-git-send-email-afaerber@suse.de> <1456789465-2962-8-git-send-email-afaerber@suse.de> Message-ID: <56D57673.8030702@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andreas, On 29/02/16 23:44, Andreas F?rber wrote: > Add GICH and GICV resources for HYP mode - guess based on other vendors. Do you know if the firmware allows the kernel to be entered in EL2 (which is the arm64 name for HYP)? So can we run kvm? If you have a booted kernel, can you grep for "EL2" and "kvm" in the dmesg? Also you should merge this patch into 3/8, same for 8/8. > Signed-off-by: Andreas F?rber > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 0ae089bd1806..5088ae3ff653 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -117,7 +117,9 @@ > gic: interrupt-controller at c4301000 { > compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; I think "arm,gic-400" is the name to use here these days, especially for arm64. > reg = <0x0 0xc4301000 0 0x1000>, > - <0x0 0xc4302000 0 0x0100>; > + <0x0 0xc4302000 0 0x0100>, Please use 0x2000 for the size here. I guess this is really the GIC-400 from ARM, and in this case this is the right size, [1] is the reference here. This will enable EOI mode 1 for KVM. Cheers, Andre. [1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html > + <0x0 0xc4304000 0 0x2000>, > + <0x0 0xc4306000 0 0x2000>; > interrupt-controller; > interrupts = (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Date: Tue, 1 Mar 2016 11:01:07 +0000 Message-ID: <56D57673.8030702@arm.com> References: <1456789465-2962-1-git-send-email-afaerber@suse.de> <1456789465-2962-8-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1456789465-2962-8-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , linux-meson-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Matthias Brugger , Pawel Moll , Ian Campbell , Catalin Marinas , Nicolas Saenz , Will Deacon , open list , Rob Herring , Kumar Gala , Carlo Caione , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Andreas, On 29/02/16 23:44, Andreas F=C3=A4rber wrote: > Add GICH and GICV resources for HYP mode - guess based on other vendo= rs. Do you know if the firmware allows the kernel to be entered in EL2 (which is the arm64 name for HYP)? So can we run kvm? If you have a booted kernel, can you grep for "EL2" and "kvm" in the dm= esg? Also you should merge this patch into 3/8, same for 8/8. > Signed-off-by: Andreas F=C3=A4rber > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64= /boot/dts/amlogic/meson-gxbb.dtsi > index 0ae089bd1806..5088ae3ff653 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -117,7 +117,9 @@ > gic: interrupt-controller@c4301000 { > compatible =3D "arm,cortex-a15-gic", "arm,cortex-a9-gic"; I think "arm,gic-400" is the name to use here these days, especially fo= r arm64. > reg =3D <0x0 0xc4301000 0 0x1000>, > - <0x0 0xc4302000 0 0x0100>; > + <0x0 0xc4302000 0 0x0100>, Please use 0x2000 for the size here. I guess this is really the GIC-400 from ARM, and in this case this is the right size, [1] is the reference here. This will enable EOI mode 1 for KVM. Cheers, Andre. [1] http://infocenter.arm.com/help/index.jsp?topic=3D/com.arm.doc.ddi0471b/= CHDIFAEE.html > + <0x0 0xc4304000 0 0x2000>, > + <0x0 0xc4306000 0 0x2000>; > interrupt-controller; > interrupts =3D (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbcCALBK (ORCPT ); Tue, 1 Mar 2016 06:01:10 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:40398 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbcCALBI (ORCPT ); Tue, 1 Mar 2016 06:01:08 -0500 Subject: Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , linux-meson@googlegroups.com References: <1456789465-2962-1-git-send-email-afaerber@suse.de> <1456789465-2962-8-git-send-email-afaerber@suse.de> Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Matthias Brugger , Pawel Moll , Ian Campbell , Catalin Marinas , Nicolas Saenz , Will Deacon , open list , Rob Herring , Kumar Gala , Carlo Caione , linux-arm-kernel@lists.infradead.org From: Andre Przywara X-Enigmail-Draft-Status: N1110 Organization: ARM Ltd. Message-ID: <56D57673.8030702@arm.com> Date: Tue, 1 Mar 2016 11:01:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1456789465-2962-8-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, On 29/02/16 23:44, Andreas Färber wrote: > Add GICH and GICV resources for HYP mode - guess based on other vendors. Do you know if the firmware allows the kernel to be entered in EL2 (which is the arm64 name for HYP)? So can we run kvm? If you have a booted kernel, can you grep for "EL2" and "kvm" in the dmesg? Also you should merge this patch into 3/8, same for 8/8. > Signed-off-by: Andreas Färber > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 0ae089bd1806..5088ae3ff653 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -117,7 +117,9 @@ > gic: interrupt-controller@c4301000 { > compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; I think "arm,gic-400" is the name to use here these days, especially for arm64. > reg = <0x0 0xc4301000 0 0x1000>, > - <0x0 0xc4302000 0 0x0100>; > + <0x0 0xc4302000 0 0x0100>, Please use 0x2000 for the size here. I guess this is really the GIC-400 from ARM, and in this case this is the right size, [1] is the reference here. This will enable EOI mode 1 for KVM. Cheers, Andre. [1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html > + <0x0 0xc4304000 0 0x2000>, > + <0x0 0xc4306000 0 0x2000>; > interrupt-controller; > interrupts = (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; >