All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>, denk <denk@post.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Add a quirk for Plantronics DA45
Date: Tue, 1 Mar 2016 12:54:39 +0100	[thread overview]
Message-ID: <56D582FF.5070606@canonical.com> (raw)
In-Reply-To: <s5h8u22wl7s.wl-tiwai@suse.de>

Actually, there is a Signed-off-by line, but it's at the wrong place. 
Also the Author/From line should state your full name.

Denk, please see below:

On 2016-03-01 11:23, Takashi Iwai wrote:
> On Tue, 01 Mar 2016 11:19:48 +0100,
> denk wrote:
>>
>> As I've got no response by now, I would like to politely ask, if the patch can be accepted now, after the requested modifications?
>
> I thought I replied you, suggesting to give a proper sign-off line.
> Without your own sign-off, we can't merge any patch from you.
> See Documentation/SubmittingPatches for details.
>
> So, please resubmit with it.
>
>
> thanks,
>
> Takashi
>
>
>>
>> Thank you very much and best
>> denk
>>
>> ----- Ursprüngliche Mail -----
>> Von: "denk" <denk@post.com>
>> An: alsa-devel@alsa-project.org
>> Gesendet: Freitag, 19. Februar 2016 14:01:02
>> Betreff: [PATCH] Add a quirk for Plantronics DA45
>>
>> Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.

Here is where sign-off-line should be: after the commit message but 
before the  "---" line.

>>
>> ---
>>   sound/usb/quirks.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
>> index 2585c17..5b03296 100644
>> --- a/sound/usb/quirks.c
>> +++ b/sound/usb/quirks.c
>> @@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
>>          case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
>>          case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
>>          case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
>> +       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
>>          case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
>>          case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
>>          case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */
>> ---
>> Signed-off-by: Dennis Kadioglu <denk@post.com>

And here where it actually is; down here it won't be picked up correctly.

>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2016-03-01 11:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 13:01 [PATCH] Add a quirk for Plantronics DA45 denk
2016-03-01 10:19 ` denk
2016-03-01 10:23   ` Takashi Iwai
2016-03-01 11:37     ` denk
2016-03-01 11:54     ` David Henningsson [this message]
2016-03-01 13:23       ` Dennis Kadioglu
  -- strict thread matches above, loose matches on Subject: below --
2016-03-01 13:23 Dennis Kadioglu
2016-03-01 13:56 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D582FF.5070606@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=denk@post.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.