From: Dave Hansen <dave@sr71.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
sfr@canb.auug.org.au, akpm@linux-foundation.org,
tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com,
peterz@infradead.org, linux-next@vger.kernel.org, deller@gmx.de
Subject: Re: [PATCH] [v3] x86, pkeys: fix siginfo ABI breakage from new field
Date: Tue, 1 Mar 2016 04:48:36 -0800 [thread overview]
Message-ID: <56D58FA4.7080001@sr71.net> (raw)
In-Reply-To: <20160301080904.GA9644@gmail.com>
On 03/01/2016 12:09 AM, Ingo Molnar wrote:
> Btw., what we should not have used in a modern user ABI are variable size
> pointers:
>
> struct {
> void __user *_lower;
> void __user *_upper;
> } _addr_bnd;
>
> we should have used constant size structure elements for that, such as __u64.
>
> Had we done that, the pkeys change would not have been a problem either.
>
> Is it too late to change that, is there any si_code=SEGV_BNDERR usage in
> user-space?
Yes, the libmpx code that gcc links in looks for si_code=SEGV_BNDERR
and, by default, will just just warn about the bounds exception (rather
than letting the app die.
This bit of code will be linked into basically anything using MPX.
next prev parent reply other threads:[~2016-03-01 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 22:17 [PATCH] [v3] x86, pkeys: fix siginfo ABI breakage from new field Dave Hansen
2016-02-29 22:33 ` Stephen Rothwell
2016-03-01 7:40 ` Ingo Molnar
2016-03-01 8:09 ` Ingo Molnar
2016-03-01 12:48 ` Dave Hansen [this message]
2016-03-01 9:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D58FA4.7080001@sr71.net \
--to=dave@sr71.net \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.