From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Date: Tue, 01 Mar 2016 13:13:43 +0000 Subject: Re: [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls Message-Id: <56D59587.3010209@redhat.com> List-Id: References: <1456826935-21043-1-git-send-email-thuth@redhat.com> <56D5823A.1050607@redhat.com> <56D585B3.3000001@redhat.com> <20160301122740.smg5c6qxaonf5kpt@hawk.localdomain> In-Reply-To: <20160301122740.smg5c6qxaonf5kpt@hawk.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Jones Cc: Laurent Vivier , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, dgibson@redhat.com, pbonzini@redhat.com On 01.03.2016 13:27, Andrew Jones wrote: > On Tue, Mar 01, 2016 at 01:06:11PM +0100, Thomas Huth wrote: >> On 01.03.2016 12:51, Laurent Vivier wrote: >>> >>> On 01/03/2016 11:08, Thomas Huth wrote: >>>> Introduce a test for sPAPR hypercalls, starting with the >>>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM. >>>> >>>> Signed-off-by: Thomas Huth ... >>> Is it possible to have a message for the H_RANDOM test, something like >>> "not supported"? >> >> I initially had something like that in my code, but the output like >> >> PASS: hypercall: h_random: not supported >> >> then also looks somewhat strange ... >> >> Is there already a common sense how to (not) report missing and thus >> untestable features in kvm-unit-tests? Something like >> >> SKIP: hypercall: h_random: not supported >> >> would be posh, I think... > > We have XFAIL (instead of SKIP). So you could maybe do something like > > report_xfail(fmt, !is_supported, test_passed, ...) Ah, that looks fine, thanks for the hint, I'll change my patch to use it! Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls Date: Tue, 1 Mar 2016 14:13:43 +0100 Message-ID: <56D59587.3010209@redhat.com> References: <1456826935-21043-1-git-send-email-thuth@redhat.com> <56D5823A.1050607@redhat.com> <56D585B3.3000001@redhat.com> <20160301122740.smg5c6qxaonf5kpt@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Laurent Vivier , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, dgibson@redhat.com, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46907 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753789AbcCANNs (ORCPT ); Tue, 1 Mar 2016 08:13:48 -0500 In-Reply-To: <20160301122740.smg5c6qxaonf5kpt@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 01.03.2016 13:27, Andrew Jones wrote: > On Tue, Mar 01, 2016 at 01:06:11PM +0100, Thomas Huth wrote: >> On 01.03.2016 12:51, Laurent Vivier wrote: >>> >>> On 01/03/2016 11:08, Thomas Huth wrote: >>>> Introduce a test for sPAPR hypercalls, starting with the >>>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM. >>>> >>>> Signed-off-by: Thomas Huth ... >>> Is it possible to have a message for the H_RANDOM test, something like >>> "not supported"? >> >> I initially had something like that in my code, but the output like >> >> PASS: hypercall: h_random: not supported >> >> then also looks somewhat strange ... >> >> Is there already a common sense how to (not) report missing and thus >> untestable features in kvm-unit-tests? Something like >> >> SKIP: hypercall: h_random: not supported >> >> would be posh, I think... > > We have XFAIL (instead of SKIP). So you could maybe do something like > > report_xfail(fmt, !is_supported, test_passed, ...) Ah, that looks fine, thanks for the hint, I'll change my patch to use it! Thomas