Re: [PULL] bcache fixes for v4.5-rc6

[Jens Axboe <axboe@kernel.dk>]

On 02/29/2016 06:08 PM, Eric Wheeler wrote:
> Hi Jens,
>
> Can we still get these in for 4.5?  One is a race, the other is just error
> handling.
>
> Please pull:
>    git pull https://bitbucket.org/ewheelerinc/linux.git v4.5-rc6-bcache-fixes
>
> bcache: fix race of writeback thread starting before complete initialization
> bcache: cleaned up error handling around register_cache()

They look simple enough, though I generally don't like collapsing things 
like this:

if ((ret = cache_alloc(sb, ca)) != 0)

it's easy to screw up, doing

ret = cache_alloc(sb, ca);
if (ret != 0)
     ...

is a lot more readable and harder to screw up. Can we get that cleaned 
up? We can still make 4.5, I've got a bunch pending that's going out 
today, and these two would have missed the boat for today anyway. But 
that doesn't mean we can't get them out later this week.

-- 
Jens Axboe