All of lore.kernel.org
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Bernhard Walle <bernhard@bwalle.de>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Cc: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT
Date: Tue, 1 Mar 2016 10:16:22 -0700	[thread overview]
Message-ID: <56D5CE66.3010602@boundarydevices.com> (raw)


We need that for a custom hardware that needs the reverse reset
sequence.

Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
---
 Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++
 drivers/net/ethernet/freescale/fec_main.c         | 8 ++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt
b/Documentation/devicetree/bindings/net/fsl-fec.txt
index a9eb611..a4799ff 100644
--- a/Documentation/devicetree/bindings/net/fsl-fec.txt
+++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
@@ -12,6 +12,9 @@ Optional properties:
   only if property "phy-reset-gpios" is available.  Missing the property
   will have the duration be 1 millisecond.  Numbers greater than 1000 are
   invalid and 1 millisecond will be used instead.
+- phy-reset-active-low : If present then the reset sequence using the GPIO
+  specified in the "phy-reset-gpios" property is reversed (H=reset state,
+  L=operation state).
____________________________


Shouldn't this be named phy-reset-active-high, as you are making the reset active high
H=reset, L= normal operation

Troy

             reply	other threads:[~2016-03-01 17:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 17:16 Troy Kisky [this message]
2016-03-02 20:05 ` [PATCH] net: fec: Add "phy-reset-active-low" property to DT Bernhard Walle
2016-03-02 20:08   ` Fabio Estevam
  -- strict thread matches above, loose matches on Subject: below --
2016-02-08 20:21 Bernhard Walle
     [not found] ` <1454962873-1941-1-git-send-email-bernhard-X9USDgGjgfuzQB+pC5nmwQ@public.gmane.org>
2016-02-08 21:46   ` Arnd Bergmann
2016-02-08 21:46     ` Arnd Bergmann
2016-02-08 21:51     ` Andrew Lunn
2016-02-08 21:51       ` Andrew Lunn
2016-02-09 14:47       ` Arnd Bergmann
2016-02-08 21:48   ` Andrew Lunn
2016-02-08 21:48     ` Andrew Lunn
2016-02-16 20:17 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D5CE66.3010602@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=arnd@arndb.de \
    --cc=bernhard@bwalle.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.