From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Baumann <Andrew.Baumann@microsoft.com>,
Stefan Weil <sw@weilnetz.de>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
QEMU Developer <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c
Date: Tue, 1 Mar 2016 18:53:26 +0100 [thread overview]
Message-ID: <56D5D716.4020903@redhat.com> (raw)
In-Reply-To: <BLUPR0301MB20343A51B6AEAF14B5B4742D9EBB0@BLUPR0301MB2034.namprd03.prod.outlook.com>
On 01/03/2016 18:46, Andrew Baumann wrote:
> --- a/include/sysemu/os-win32.h
> +++ b/include/sysemu/os-win32.h
> @@ -60,6 +60,7 @@
> * If this parameter is NULL, longjump does no stack unwinding.
> * That is what we need for QEMU. Passing the value of register rsp (default)
> * lets longjmp try a stack unwinding which will crash with generated code. */
> +# include <setjmp.h>
> # undef setjmp
> # define setjmp(env) _setjmp(env, NULL)
> #endif
I like this patch or the similar:
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 4538fdc..322a7da 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -77,6 +77,8 @@ extern int daemon(int, int);
#include <sys/time.h>
#include <assert.h>
#include <signal.h>
+/* This is needed on Mingw-w64 where we redefine setjmp below. */
+#include <setjmp.h>
#ifdef __OpenBSD__
#include <sys/signal.h>
which also includes the file on POSIX systems.
Paolo
next prev parent reply other threads:[~2016-03-01 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 5:07 [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c Stefan Weil
2016-03-01 6:23 ` Andrew Baumann
2016-03-01 9:59 ` Peter Maydell
2016-03-01 11:54 ` Stefan Weil
2016-03-01 12:22 ` Peter Maydell
2016-03-01 13:15 ` Stefan Weil
2016-03-01 17:46 ` Andrew Baumann
2016-03-01 17:53 ` Paolo Bonzini [this message]
2016-03-01 17:54 ` Peter Maydell
2016-03-01 19:08 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5D716.4020903@redhat.com \
--to=pbonzini@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=crosthwaite.peter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.