All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH 1/2] disk: Add support for device-specific malloc function
Date: Tue, 1 Mar 2016 22:46:16 +0300	[thread overview]
Message-ID: <56D5F188.6010306@gmail.com> (raw)
In-Reply-To: <CAF7UmSwm3d79Yw4Wz+xwpP97e4re6rsqxkyB5+r8=J6z2F8K2Q@mail.gmail.com>

01.03.2016 20:11, Leif Lindholm пишет:
> On 24 February 2016 at 17:40, Andrei Borzenkov <arvidjaar@gmail.com> wrote:
>> 24.02.2016 16:57, Leif Lindholm пишет:
>>> On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote:
>>>>>> Could you test attached patch with your alignment fixes on top. This
>>>>>> implements my idea of using shared buffers. Seems to work in naive testing.
>>>>>
>>>>> Testing this with a grub-mkstandalone image, I get:
>>>>>
>>>>> kern/dl.c:556: flushing 0x10f1 bytes at 0x9ffb5ac20
>>>>> kern/dl.c:649: module name: tar
>>>>> kern/dl.c:650: init function: 0x9ffb5b220
>>>>> kern/disk.c:217: Opening `memdisk'...
>>>>> kern/fs.c:56: Detecting tarfs...
>>>>>
>>>>> And then spectacular crash in UEFI due to an EL2 translation fault.
>>>>
>>>> To be sure - is it with my patch alone or with your patches? If some
>>>> more patches are used - could you send exact diff to trunk to avoid
>>>> misunderstanding?
>>>
>>> Double checked with only your patch on top of
>>> 1b782e902e69516f82158203674d4951a40c82d4 (previously running with
>>> _only_ my alignment fixup in efidisk.c). Same behaviour.
>>
>> I cannot reproduce it on x86_64 (also with mm-debug enabled) and I do
>> not know how to load standalone image on ppc; is it possible to use QEMU
>> to run ARM64 (I assume you have it)? If not what are options to test it?
>>
>> Anyway, there was one problem I fixed later (although I did not get any
>> issue before as well), I attach updated version. Thank you for testing!
> 
> I can confirm that:
> 1) The first patch exhibits no bad behaviour on QEMU [1].
> 2) The second patch exhibits no bad behaviour on either QEMU nor HW.
> 
> This still generates fixups in efidisk for each call though.

Of course; it was intended to add framework for direct-to-cache IO, it
did not change alignment.

> Could I rework my disk->malloc patch on top of this for 2.02 release?
> 

Of course! Not sure whether it is 2.02 material though, but we can keep
it in next then. Hopefully 2.03 won't take so long :)

> /
>     Leif
> 
> [1] qemu-system-aarch64 -m 1024 -cpu cortex-a57 -M virt -bios
> QEMU_EFI.fd -nographic -hda fat:fat/
> With QEMU_EFI.fd from
> http://releases.linaro.org/components/kernel/uefi-linaro/16.02/debug/qemu64/
> And fat/ being a directory holding the image generated with grub-mkstandalone.
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



  reply	other threads:[~2016-03-01 19:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 16:18 [PATCH 0/2] Alternative efidisk alignment resolution Leif Lindholm
2016-02-19 16:18 ` [PATCH 1/2] disk: Add support for device-specific malloc function Leif Lindholm
2016-02-22  7:57   ` Andrei Borzenkov
2016-02-22 14:02     ` Leif Lindholm
2016-02-22 16:56       ` Andrei Borzenkov
2016-02-24 11:59         ` Leif Lindholm
2016-02-24 12:09           ` Andrei Borzenkov
2016-02-24 13:57             ` Leif Lindholm
2016-02-24 17:40               ` Andrei Borzenkov
2016-02-24 19:04                 ` Andrei Borzenkov
2016-02-26 13:27                   ` Vladimir 'phcoder' Serbinenko
2016-02-26 13:48                     ` Andrei Borzenkov
2016-02-26 13:52                       ` Vladimir 'phcoder' Serbinenko
2016-03-01 17:11                 ` Leif Lindholm
2016-03-01 19:46                   ` Andrei Borzenkov [this message]
2016-03-01 20:19                     ` Leif Lindholm
2016-02-22 16:57   ` Andrei Borzenkov
2016-02-22 16:59     ` Vladimir 'phcoder' Serbinenko
2016-02-19 16:18 ` [PATCH 2/2] efidisk: respect block_io_protocol minimum buffer alignment Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D5F188.6010306@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.