From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: drm/amdgpu: Don't hang in amdgpu_flip_work_func on disabled crtc. Date: Tue, 1 Mar 2016 21:35:21 +0100 Message-ID: <56D5FD09.1060803@gmail.com> References: <20160229201007.GA32069@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EC58887AE for ; Tue, 1 Mar 2016 20:35:26 +0000 (UTC) Received: by mail-wm0-x229.google.com with SMTP id l68so50330326wml.1 for ; Tue, 01 Mar 2016 12:35:26 -0800 (PST) In-Reply-To: <20160229201007.GA32069@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMDIvMjkvMjAxNiAwOToxMCBQTSwgRGFuIENhcnBlbnRlciB3cm90ZToKPiBIZWxsbyBNYXJp byBLbGVpbmVyLAo+Cj4gVGhlIHBhdGNoIGUxZDA5ZGMwY2NjNjogImRybS9hbWRncHU6IERvbid0 IGhhbmcgaW4KPiBhbWRncHVfZmxpcF93b3JrX2Z1bmMgb24gZGlzYWJsZWQgY3J0Yy4iIGZyb20g RmViIDE5LCAyMDE2LCBsZWFkcyB0bwo+IHRoZSBmb2xsb3dpbmcgc3RhdGljIGNoZWNrZXIgd2Fy bmluZzoKPgo+IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kaXNwbGF5LmM6MTI3 IGFtZGdwdV9mbGlwX3dvcmtfZnVuYygpCXdhcm46IHNob3VsZCB0aGlzIGJlICdyZXBjbnQgPT0g LTEnCj4gZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXkuYzoxMzYgYW1k Z3B1X2ZsaXBfd29ya19mdW5jKCkgZXJyb3I6IGRvdWJsZSB1bmxvY2sgJ3NwaW5fbG9jazomY3J0 Yy0+ZGV2LT5ldmVudF9sb2NrJwo+IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9k aXNwbGF5LmM6MTM2IGFtZGdwdV9mbGlwX3dvcmtfZnVuYygpIGVycm9yOiBkb3VibGUgdW5sb2Nr ICdpcnFzYXZlOmZsYWdzJwo+Cj4KPiBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf ZGlzcGxheS5jCj4gICAgICA2NCAgc3RhdGljIHZvaWQgYW1kZ3B1X2ZsaXBfd29ya19mdW5jKHN0 cnVjdCB3b3JrX3N0cnVjdCAqX193b3JrKQo+ICAgICAgNjUgIHsKPiAgICAgIDY2ICAgICAgICAg IHN0cnVjdCBhbWRncHVfZmxpcF93b3JrICp3b3JrID0KPiAgICAgIDY3ICAgICAgICAgICAgICAg ICAgY29udGFpbmVyX29mKF9fd29yaywgc3RydWN0IGFtZGdwdV9mbGlwX3dvcmssIGZsaXBfd29y ayk7Cj4gICAgICA2OCAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IHdvcmst PmFkZXY7Cj4gICAgICA2OSAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1X2NydGMgKmFtZGdwdUNydGMg PSBhZGV2LT5tb2RlX2luZm8uY3J0Y3Nbd29yay0+Y3J0Y19pZF07Cj4gICAgICA3MAo+ICAgICAg NzEgICAgICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjID0gJmFtZGdwdUNydGMtPmJhc2U7Cj4g ICAgICA3MiAgICAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICAgICAgNzMgICAgICAgICAg dW5zaWduZWQgaSwgcmVwY250ID0gNDsKPiAgICAgIDc0ICAgICAgICAgIGludCB2cG9zLCBocG9z LCBzdGF0LCBtaW5fdWRlbGF5ID0gMDsKPiAgICAgIDc1ICAgICAgICAgIHN0cnVjdCBkcm1fdmJs YW5rX2NydGMgKnZibGFuayA9ICZjcnRjLT5kZXYtPnZibGFua1t3b3JrLT5jcnRjX2lkXTsKPiAg ICAgIDc2Cj4gICAgICA3NyAgICAgICAgICBpZiAoYW1kZ3B1X2ZsaXBfaGFuZGxlX2ZlbmNlKHdv cmssICZ3b3JrLT5leGNsKSkKPiAgICAgIDc4ICAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ICAg ICAgNzkKPiAgICAgIDgwICAgICAgICAgIGZvciAoaSA9IDA7IGkgPCB3b3JrLT5zaGFyZWRfY291 bnQ7ICsraSkKPiAgICAgIDgxICAgICAgICAgICAgICAgICAgaWYgKGFtZGdwdV9mbGlwX2hhbmRs ZV9mZW5jZSh3b3JrLCAmd29yay0+c2hhcmVkW2ldKSkKPiAgICAgIDgyICAgICAgICAgICAgICAg ICAgICAgICAgICByZXR1cm47Cj4gICAgICA4Mwo+ICAgICAgODQgICAgICAgICAgLyogV2UgYm9y cm93IHRoZSBldmVudCBzcGluIGxvY2sgZm9yIHByb3RlY3RpbmcgZmxpcF9zdGF0dXMgKi8KPiAg ICAgIDg1ICAgICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ss IGZsYWdzKTsKPiAgICAgIDg2Cj4gICAgICA4NyAgICAgICAgICAvKiBJZiB0aGlzIGhhcHBlbnMg dG8gZXhlY3V0ZSB3aXRoaW4gdGhlICJ2aXJ0dWFsbHkgZXh0ZW5kZWQiIHZibGFuawo+ICAgICAg ODggICAgICAgICAgICogaW50ZXJ2YWwgYmVmb3JlIHRoZSBzdGFydCBvZiB0aGUgcmVhbCB2Ymxh bmsgaW50ZXJ2YWwgdGhlbiBpdCBuZWVkcwo+ICAgICAgODkgICAgICAgICAgICogdG8gZGVsYXkg cHJvZ3JhbW1pbmcgdGhlIG1taW8gZmxpcCB1bnRpbCB0aGUgcmVhbCB2YmxhbmsgaXMgZW50ZXJl ZC4KPiAgICAgIDkwICAgICAgICAgICAqIFRoaXMgcHJldmVudHMgY29tcGxldGluZyBhIGZsaXAg dG9vIGVhcmx5IGR1ZSB0byB0aGUgd2F5IHdlIGZ1ZGdlCj4gICAgICA5MSAgICAgICAgICAgKiBv dXIgdmJsYW5rIGNvdW50ZXIgYW5kIHZibGFuayB0aW1lc3RhbXBzIGluIG9yZGVyIHRvIHdvcmsg YXJvdW5kIHRoZQo+ICAgICAgOTIgICAgICAgICAgICogcHJvYmxlbSB0aGF0IHRoZSBodyBmaXJl cyB2YmxhbmsgaW50ZXJydXB0cyBiZWZvcmUgYWN0dWFsIHN0YXJ0IG9mCj4gICAgICA5MyAgICAg ICAgICAgKiB2YmxhbmsgKHdoZW4gbGluZSBidWZmZXIgcmVmaWxsaW5nIGlzIGRvbmUgZm9yIGEg ZnJhbWUpLiBJdAo+ICAgICAgOTQgICAgICAgICAgICogY29tcGxlbWVudHMgdGhlIGZ1ZGdpbmcg bG9naWMgaW4gYW1kZ3B1X2dldF9jcnRjX3NjYW5vdXRwb3MoKSBmb3IKPiAgICAgIDk1ICAgICAg ICAgICAqIHRpbWVzdGFtcGluZyBhbmQgYW1kZ3B1X2dldF92YmxhbmtfY291bnRlcl9rbXMoKSBm b3IgdmJsYW5rIGNvdW50cy4KPiAgICAgIDk2ICAgICAgICAgICAqCj4gICAgICA5NyAgICAgICAg ICAgKiBJbiBwcmFjdGljZSB0aGlzIHdvbid0IGV4ZWN1dGUgdmVyeSBvZnRlbiB1bmxlc3Mgb24g dmVyeSBmYXN0Cj4gICAgICA5OCAgICAgICAgICAgKiBtYWNoaW5lcyBiZWNhdXNlIHRoZSB0aW1l IHdpbmRvdyBmb3IgdGhpcyB0byBoYXBwZW4gaXMgdmVyeSBzbWFsbC4KPiAgICAgIDk5ICAgICAg ICAgICAqLwo+ICAgICAxMDAgICAgICAgICAgd2hpbGUgKGFtZGdwdUNydGMtPmVuYWJsZWQgJiYg cmVwY250LS0pIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF5eXl5eXl5eCj4gRXhpc3RzIHRoZSBsb29wIHdpdGggc3Bpbl9sb2NrIGhlbGQgYW5kIHJl cGNudCA9PSAtMS4KPgo+Cj4gICAgIDEwMSAgICAgICAgICAgICAgICAgIC8qIEdFVF9ESVNUQU5D RV9UT19WQkxBTktTVEFSVCByZXR1cm5zIGRpc3RhbmNlIHRvIHJlYWwgdmJsYW5rCj4gICAgIDEw MiAgICAgICAgICAgICAgICAgICAqIHN0YXJ0IGluIGhwb3MsIGFuZCB0byB0aGUgImZ1ZGdlZCBl YXJsaWVyIiB2Ymxhbmsgc3RhcnQgaW4KPiAgICAgMTAzICAgICAgICAgICAgICAgICAgICogdnBv cy4KPiAgICAgMTA0ICAgICAgICAgICAgICAgICAgICovCj4gICAgIDEwNSAgICAgICAgICAgICAg ICAgIHN0YXQgPSBhbWRncHVfZ2V0X2NydGNfc2Nhbm91dHBvcyhhZGV2LT5kZGV2LCB3b3JrLT5j cnRjX2lkLAo+ICAgICAxMDYgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgR0VUX0RJU1RBTkNFX1RPX1ZCTEFOS1NUQVJULAo+ICAgICAxMDcgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnZwb3MsICZocG9z LCBOVUxMLCBOVUxMLAo+ICAgICAxMDggICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJmNydGMtPmh3bW9kZSk7Cj4gICAgIDEwOQo+ICAgICAxMTAgICAg ICAgICAgICAgICAgICBpZiAoKHN0YXQgJiAoRFJNX1NDQU5PVVRQT1NfVkFMSUQgfCBEUk1fU0NB Tk9VVFBPU19BQ0NVUkFURSkpICE9Cj4gICAgIDExMSAgICAgICAgICAgICAgICAgICAgICAoRFJN X1NDQU5PVVRQT1NfVkFMSUQgfCBEUk1fU0NBTk9VVFBPU19BQ0NVUkFURSkgfHwKPiAgICAgMTEy ICAgICAgICAgICAgICAgICAgICAgICEodnBvcyA+PSAwICYmIGhwb3MgPD0gMCkpCj4gICAgIDEx MyAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAgIDExNAo+ICAgICAxMTUgICAg ICAgICAgICAgICAgICAvKiBTbGVlcCBhdCBsZWFzdCB1bnRpbCBlc3RpbWF0ZWQgcmVhbCBzdGFy dCBvZiBodyB2YmxhbmsgKi8KPiAgICAgMTE2ICAgICAgICAgICAgICAgICAgc3Bpbl91bmxvY2tf aXJxcmVzdG9yZSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gICAgIDExNyAgICAg ICAgICAgICAgICAgIG1pbl91ZGVsYXkgPSAoLWhwb3MgKyAxKSAqIG1heCh2YmxhbmstPmxpbmVk dXJfbnMgLyAxMDAwLCA1KTsKPiAgICAgMTE4ICAgICAgICAgICAgICAgICAgaWYgKG1pbl91ZGVs YXkgPiB2YmxhbmstPmZyYW1lZHVyX25zIC8gMjAwMCkgewo+ICAgICAxMTkgICAgICAgICAgICAg ICAgICAgICAgICAgIC8qIERvbid0IHdhaXQgcmlkaWN1bG91c2x5IGxvbmcgLSBzb21ldGhpbmcg aXMgd3JvbmcgKi8KPiAgICAgMTIwICAgICAgICAgICAgICAgICAgICAgICAgICByZXBjbnQgPSAw Owo+Cj4gRXhpdCB3aXRoIHNwaW5fbG9jayByZWxlYXNlZCBhbmQgcmVwY250ID09IDAuCj4KPiAg ICAgMTIxICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiAgICAgMTIyICAgICAgICAg ICAgICAgICAgfQo+ICAgICAxMjMgICAgICAgICAgICAgICAgICB1c2xlZXBfcmFuZ2UobWluX3Vk ZWxheSwgMiAqIG1pbl91ZGVsYXkpOwo+ICAgICAxMjQgICAgICAgICAgICAgICAgICBzcGluX2xv Y2tfaXJxc2F2ZSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gICAgIDEyNSAgICAg ICAgICB9Owo+ICAgICAxMjYKPiAgICAgMTI3ICAgICAgICAgIGlmICghcmVwY250KQo+ICAgICAg ICAgICAgICAgICAgICAgICBeXl5eXl4KPiBBc3N1bWVzIGV4aXQgd2l0aCB6ZXJvLgo+Cj4gICAg IDEyOCAgICAgICAgICAgICAgICAgIERSTV9ERUJVR19EUklWRVIoIkRlbGF5IHByb2JsZW0gb24g Y3J0YyAlZDogbWluX3VkZWxheSAlZCwgIgo+ICAgICAxMjkgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJmcmFtZWR1ciAlZCwgbGluZWR1ciAlZCwgc3RhdCAlZCwgdnBvcyAlZCwg Igo+ICAgICAxMzAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJocG9zICVkXG4i LCB3b3JrLT5jcnRjX2lkLCBtaW5fdWRlbGF5LAo+ICAgICAxMzEgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHZibGFuay0+ZnJhbWVkdXJfbnMgLyAxMDAwLAo+ICAgICAxMzIgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZibGFuay0+bGluZWR1cl9ucyAvIDEwMDAs IHN0YXQsIHZwb3MsIGhwb3MpOwo+ICAgICAxMzMKPiAgICAgMTM0ICAgICAgICAgIC8qIHNldCB0 aGUgZmxpcCBzdGF0dXMgKi8KPiAgICAgMTM1ICAgICAgICAgIGFtZGdwdUNydGMtPnBmbGlwX3N0 YXR1cyA9IEFNREdQVV9GTElQX1NVQk1JVFRFRDsKPiAgICAgMTM2ICAgICAgICAgIHNwaW5fdW5s b2NrX2lycXJlc3RvcmUoJmNydGMtPmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+Cj4gQXNzdW1l cyBsb2NrIGhlbGQuCj4KPiAgICAgMTM3Cj4gICAgIDEzOCAgICAgICAgICAvKiBEbyB0aGUgZmxp cCAobW1pbykgKi8KPiAgICAgMTM5ICAgICAgICAgIGFkZXYtPm1vZGVfaW5mby5mdW5jcy0+cGFn ZV9mbGlwKGFkZXYsIHdvcmstPmNydGNfaWQsIHdvcmstPmJhc2UpOwo+ICAgICAxNDAgIH0KPgo+ IHJlZ2FyZHMsCj4gZGFuIGNhcnBlbnRlcgo+CgpFcnJvcnMgZHVyaW5nIGVycm9yIGhhbmRsaW5n LCBteSBmYXZvcml0ZSBidWdzLiBUaGFua3MgZm9yIHNwb3R0aW5nIAp0aGlzISBQYXRjaGVzIGFy ZSBvdXQgZm9yIHJldmlldy4KCi1tYXJpbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==