From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Feiner <pfeiner@google.com>,
kvm@vger.kernel.org, jan.kiszka@siemens.com
Subject: Re: [kvm-unit-tests 0/5] Split large EPT mappings properly
Date: Tue, 1 Mar 2016 22:13:33 +0100 [thread overview]
Message-ID: <56D605FD.5020107@redhat.com> (raw)
In-Reply-To: <1456860622-31251-1-git-send-email-pfeiner@google.com>
On 01/03/2016 20:30, Peter Feiner wrote:
> install_ept_entry would overwrite arbitrary memory when it encountered
> a large page.
>
> I discovered the bug while working on a simple multi-page allocator,
> which I'm using for huge page testing, that sorts the free list in
> ascending order of HPA.
>
> Peter Feiner (5):
> x86: vmx.h: trivial whitespace fixes
> x86: vmx: Named constant: EPT_ADDR_MASK
> x86: vmx: Named constant: EPT_LEVEL_SHIFT
> x86: vmx: split large EPTEs in install_ept_entry
> x86: vmx: don't explicitly split identity EPT map
>
> x86/vmx.c | 65 +++++++++++++++++++++++++++++++++++++++++++--------------
> x86/vmx.h | 9 +++++---
> x86/vmx_tests.c | 7 -------
> 3 files changed, 55 insertions(+), 26 deletions(-)
Looks good apart for not reusing PAGE_MASK in patch 2. Thanks!
Paolo
next prev parent reply other threads:[~2016-03-01 21:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 19:30 [kvm-unit-tests 0/5] Split large EPT mappings properly Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 1/5] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 2/5] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-01 21:12 ` Paolo Bonzini
2016-03-01 21:16 ` Peter Feiner
2016-03-01 21:27 ` Jan Kiszka
2016-03-01 21:36 ` Paolo Bonzini
2016-03-01 19:30 ` [kvm-unit-tests 3/5] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 4/5] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 5/5] x86: vmx: don't explicitly split identity EPT map Peter Feiner
2016-03-01 21:13 ` Paolo Bonzini [this message]
2016-03-01 22:34 ` [kvm-unit-tests v2 0/6] Split large EPT mappings properly Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 1/6] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 2/6] lib: generic bitops.h Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 3/6] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-02 6:24 ` Jan Kiszka
2016-03-02 8:47 ` Paolo Bonzini
2016-03-02 16:50 ` Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 4/6] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 5/6] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 6/6] x86: vmx: don't explicitly split identity EPT map Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 0/6] Split large EPT mappings properly Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 1/6] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 2/6] lib: generic bitops.h Peter Feiner
2016-03-02 18:13 ` Andrew Jones
2016-03-02 17:10 ` [kvm-unit-tests v3 3/6] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 4/6] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 5/6] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 6/6] x86: vmx: don't explicitly split identity EPT map Peter Feiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D605FD.5020107@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=pfeiner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.