All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 3/4] pmu/fuc: call# seems to be broken on gk208
Date: Wed, 2 Mar 2016 00:27:57 +0200	[thread overview]
Message-ID: <56D6176D.9080808@free.fr> (raw)
In-Reply-To: <CAKb7UvgKF9deHTrP-PuB6WL=02OjMmUoi4qksDiboSucRVYR8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



On 01/03/16 23:53, Ilia Mirkin wrote:
> On Tue, Mar 1, 2016 at 4:45 PM, Martin Peres <martin.peres@free.fr> wrote:
>> On 26/02/16 17:19, Karol Herbst wrote:
>>> for some reasons these calls don't really go there where they should go
>>> leading to various corruptions of the PMU state
>>
>> I am fine with the changes but not fine at all with the commit message. it
>> would be nice if you could understand a bit more what the problem is instead
>> of just saying: "it works with this change (TM)"
> The problem is that the call macro exists for a reason, but it was
> (accidentally) not being used here.

Agreed, I checked before sending this email. Hence why I was fine with 
the change but not the change log.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2016-03-01 22:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 15:19 [PATCH 0/4] fix pmu code on gk208+ Karol Herbst
     [not found] ` <1456499974-1950-1-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-02-26 15:19   ` [PATCH 1/4] pmu/fuc: fix imm32 for gk208+ Karol Herbst
     [not found]     ` <1456499974-1950-2-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-01 21:38       ` Martin Peres
2016-02-26 15:19   ` [PATCH 2/4] pmu/fuc: replace mov+sethi with imm32 Karol Herbst
     [not found]     ` <1456499974-1950-3-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-01 21:40       ` Martin Peres
2016-02-26 15:19   ` [PATCH 3/4] pmu/fuc: call# seems to be broken on gk208 Karol Herbst
     [not found]     ` <1456499974-1950-4-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-01 21:45       ` Martin Peres
     [not found]         ` <56D60D6B.7010808-GANU6spQydw@public.gmane.org>
2016-03-01 21:53           ` Ilia Mirkin
     [not found]             ` <CAKb7UvgKF9deHTrP-PuB6WL=02OjMmUoi4qksDiboSucRVYR8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-01 22:27               ` Martin Peres [this message]
2016-02-26 15:19   ` [PATCH 4/4] pmu/fuc: movw is somewhat weird on gk208, use mov instead Karol Herbst
     [not found]     ` <1456499974-1950-5-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-01 21:36       ` Martin Peres
     [not found]         ` <56D60B4C.3010108-GANU6spQydw@public.gmane.org>
2016-03-01 21:38           ` Ilia Mirkin
     [not found]             ` <CAKb7UvgFX8YzWZi_HHn6U2pzwu7kFU=DQHoBgJowOjj=jgucOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-01 21:46               ` Martin Peres
     [not found]                 ` <56D60DB6.1030209-GANU6spQydw@public.gmane.org>
2016-03-01 22:42                   ` Karol Herbst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D6176D.9080808@free.fr \
    --to=martin.peres-ganu6spqydw@public.gmane.org \
    --cc=imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.