Re: [Qemu-devel] [PATCH] MacKeys.h: initial commit

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On 03/01/2016 04:08 PM, Peter Maydell wrote:
> On 1 March 2016 at 22:07, Programmingkid <programmingkidx@gmail.com> wrote:
>> This patch adds the file MacKeys.h. It is a file that contains all the constants
>> for the Macintosh keyboard keycodes.
>>
>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>>
>> ---
>> Note to Peter Maydell:
>> I know you wanted me to use the constants from the file HIToolbox/Events.h, but
>> I can't. It only exists on Mac OS X, so other operating systems like Linux
>> would not be able to use it. This file is also used in the adb.c file, so
>> cross-platform compatibility is a must.
> 
> What I suggested was that you should use the Events.h constants in
> ui/cocoa.m (which is OSX only) and have a file in include/hw/input/
> for the keys for the ADB keyboard emulation.
> 
> This patch should really be in a patch series with the patches that
> use the new header.
> 
>>  include/hw/input/MacKeys.h |  139 ++++++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 139 insertions(+), 0 deletions(-)
>>  create mode 100644 include/hw/input/MacKeys.h

Can we please use lower-case naming of mac-keys.h?  Just because Mac
headers use Capital Names doesn't mean we have to break our internal
conventions to follow.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]