All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] OMAP3: Various: Future-proof serial platdata
Date: Wed, 2 Mar 2016 01:01:23 +0100	[thread overview]
Message-ID: <56D62D53.6060901@suse.de> (raw)
In-Reply-To: <1456874609-29666-1-git-send-email-aford173@gmail.com>



On 02.03.16 00:23, Adam Ford wrote:
> A few boards still use ns16550_platdata structures, but assume the structure
> is going to be in a specific order. By explicitly naming each entry,
> this should also help 'future-proof' in the event the structure changes.
> 
> Tested on the Logic PD Torpedo + Wireless.
> 
> I only changed a handful of devices that used the same syntax as the Logic
> board.  Appologies if I missed one or stepped on toes.  Thanks to Derald Woods
> and Alexander Graf.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> V4: Fix subject heading
> 
> V3: Remove  reg_offset out in all the structs. It was reverted out, and and if
> it did exist, it would get initialized to 0 by default.
> 
> V2: I hastily copy-pasted the boards without looking at the UART number.
> This addresses 3 boards that use UART3 and not UART1.
> ---
>  board/isee/igep00x0/igep00x0.c      | 6 +++---
>  board/logicpd/omap3som/omap3logic.c | 6 +++---
>  board/logicpd/zoom1/zoom1.c         | 6 +++---
>  board/overo/overo.c                 | 6 +++---
>  board/quipos/cairo/cairo.c          | 6 +++---
>  board/ti/beagle/beagle.c            | 6 +++---
>  board/timll/devkit8000/devkit8000.c | 6 +++---

Looks to me like you didn't catch all boards out there. I don't think it
makes sense to limit yourself to OMAP3, otherwise different boards (that
people may not realize are broken that fast) break next time...

arch/arm/cpu/arm926ejs/lpc32xx/devices.c
arch/arm/cpu/armv7/am33xx/board.c
arch/arm/mach-tegra/board.c
board/isee/igep00x0/igep00x0.c
board/lge/sniper/sniper.c
board/logicpd/omap3som/omap3logic.c
board/logicpd/zoom1/zoom1.c
board/overo/overo.c
board/quipos/cairo/cairo.c
board/ti/beagle/beagle.c
board/timll/devkit8000/devkit8000.c


Alex

  reply	other threads:[~2016-03-02  0:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 23:23 [U-Boot] [PATCH V4] OMAP3: Various: Future-proof serial platdata Adam Ford
2016-03-02  0:01 ` Alexander Graf [this message]
2016-03-02  0:05   ` Adam Ford
2016-03-02  0:31     ` Alexander Graf
2016-03-02 11:29   ` Adam Ford
2016-03-02 15:13     ` Alexander Graf
2016-03-03 15:44       ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D62D53.6060901@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.