From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com. [210.118.77.11]) by gmr-mx.google.com with ESMTPS id ui7si4801784pab.0.2016.03.01.17.00.33 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 01 Mar 2016 17:00:33 -0800 (PST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O3E00F8404TU260@mailout1.w1.samsung.com> for rtc-linux@googlegroups.com; Wed, 02 Mar 2016 01:00:29 +0000 (GMT) Subject: [rtc-linux] Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation To: Laxman Dewangan , alexandre.belloni@free-electrons.com, a.zummo@towertech.it References: <1456750705-13579-1-git-send-email-ldewangan@nvidia.com> <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, javier@osg.samsung.com, rklein@nvidia.com From: Krzysztof Kozlowski Message-id: <56D63B28.9030502@samsung.com> Date: Wed, 02 Mar 2016 10:00:24 +0900 MIME-version: 1.0 In-reply-to: <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 29.02.2016 21:58, Laxman Dewangan wrote: > use macro REGMAP_IRQ_REG from regmap.h to initialise the > regmap irq table for max77686. Why? Any benefits? Best regards, Krzysztof > > Signed-off-by: Laxman Dewangan > --- > drivers/rtc/rtc-max77686.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index 39d529a..0cb422b 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -174,12 +174,12 @@ static const unsigned int max77686_map[REG_RTC_END] = { > > static const struct regmap_irq max77686_rtc_irqs[] = { > /* RTC interrupts */ > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTC60S_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTCA1_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTCA2_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_SMPL_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTC1S_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_WTSR_MSK, }, > + REGMAP_IRQ_REG(0, 0, MAX77686_RTCINT_RTC60S_MSK), > + REGMAP_IRQ_REG(1, 0, MAX77686_RTCINT_RTCA1_MSK), > + REGMAP_IRQ_REG(2, 0, MAX77686_RTCINT_RTCA2_MSK), > + REGMAP_IRQ_REG(3, 0, MAX77686_RTCINT_SMPL_MSK), > + REGMAP_IRQ_REG(4, 0, MAX77686_RTCINT_RTC1S_MSK), > + REGMAP_IRQ_REG(5, 0, MAX77686_RTCINT_WTSR_MSK), > }; > > static const struct regmap_irq_chip max77686_rtc_irq_chip = { > -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756291AbcCBBAg (ORCPT ); Tue, 1 Mar 2016 20:00:36 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:59154 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755939AbcCBBAc (ORCPT ); Tue, 1 Mar 2016 20:00:32 -0500 X-AuditID: cbfec7f4-f79026d00000418a-54-56d63b2cc1bb Subject: Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation To: Laxman Dewangan , alexandre.belloni@free-electrons.com, a.zummo@towertech.it References: <1456750705-13579-1-git-send-email-ldewangan@nvidia.com> <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, javier@osg.samsung.com, rklein@nvidia.com From: Krzysztof Kozlowski Message-id: <56D63B28.9030502@samsung.com> Date: Wed, 02 Mar 2016 10:00:24 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xq7o61tfCDH5NMbNYcvEqu0XHtcVM Fte/PGe1ePN2DZPF6xeGFkv3rWaxuLxrDpvFsuOrWS32d3YwOnB6PNl0kdFjz8STbB69ze/Y PLb032X36NuyitFj+ryfTB6fN8kFsEdx2aSk5mSWpRbp2yVwZazvOc5ecIm7ouXzUfYGxhuc XYycHBICJhJTdp9khbDFJC7cW88GYgsJLGWUWDDVuIuRC8h+yijx6+kTJpCEsEC8xPXmOyxd jBwcIgIZEicXeELU10tcfruPBaSeWaCBUeJ870Z2kASbgLHE5uVLwIbyCmhJPJz9mgXEZhFQ lfjR9gusRlQgQuJwZxc7RI2gxI/J98BqOAVcJdZ0nWUE2cUsoCdx/6IWSJhZQF5i85q3zBMY BWYh6ZiFUDULSdUCRuZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmbGCFx8GUH4+JjVocYBTgY lXh4Mz5dDRNiTSwrrsw9xCjBwawkwjvH4lqYEG9KYmVValF+fFFpTmrxIUZpDhYlcd65u96H CAmkJ5akZqemFqQWwWSZODilGhgZ93eWfmip8fq/7NQVzuXatXKddpEF2lu2lO2dWbpD45j9 hhiHondZa+dvM5hnJ7hvFWv21zN6f18/67pjdIijQsBZzXNhqdTrmnhuvpZU60brrS1Gjjsn pNZ22LRt9GUqN/8hWmOwate7cKUthXrX44PdXkwxrDzGKL6o6oEi09Rp86y8fyuxFGckGmox FxUnAgDzNiyQfwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.02.2016 21:58, Laxman Dewangan wrote: > use macro REGMAP_IRQ_REG from regmap.h to initialise the > regmap irq table for max77686. Why? Any benefits? Best regards, Krzysztof > > Signed-off-by: Laxman Dewangan > --- > drivers/rtc/rtc-max77686.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index 39d529a..0cb422b 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -174,12 +174,12 @@ static const unsigned int max77686_map[REG_RTC_END] = { > > static const struct regmap_irq max77686_rtc_irqs[] = { > /* RTC interrupts */ > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTC60S_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTCA1_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTCA2_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_SMPL_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_RTC1S_MSK, }, > - { .reg_offset = 0, .mask = MAX77686_RTCINT_WTSR_MSK, }, > + REGMAP_IRQ_REG(0, 0, MAX77686_RTCINT_RTC60S_MSK), > + REGMAP_IRQ_REG(1, 0, MAX77686_RTCINT_RTCA1_MSK), > + REGMAP_IRQ_REG(2, 0, MAX77686_RTCINT_RTCA2_MSK), > + REGMAP_IRQ_REG(3, 0, MAX77686_RTCINT_SMPL_MSK), > + REGMAP_IRQ_REG(4, 0, MAX77686_RTCINT_RTC1S_MSK), > + REGMAP_IRQ_REG(5, 0, MAX77686_RTCINT_WTSR_MSK), > }; > > static const struct regmap_irq_chip max77686_rtc_irq_chip = { >