From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com. [216.228.121.143]) by gmr-mx.google.com with ESMTPS id ui7si4840218pab.0.2016.03.01.18.16.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 18:16:57 -0800 (PST) Message-ID: <56D64A25.5050700@nvidia.com> Date: Wed, 2 Mar 2016 07:34:21 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Krzysztof Kozlowski , , CC: , , , , Subject: [rtc-linux] Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation References: <1456750705-13579-1-git-send-email-ldewangan@nvidia.com> <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> <56D63B28.9030502@samsung.com> In-Reply-To: <56D63B28.9030502@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: > On 29.02.2016 21:58, Laxman Dewangan wrote: >> use macro REGMAP_IRQ_REG from regmap.h to initialise the >> regmap irq table for max77686. > Why? Any benefits? > > I think it is better coding to use macro for member initializations instead of doing it locally and it improves readability. I got the similar comment from Lee's in my MFD patches to use macro for such initialization and I agreed with him. As I was here on this driver, thought to use macro. -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757014AbcCBCRG (ORCPT ); Tue, 1 Mar 2016 21:17:06 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:16585 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753219AbcCBCRD (ORCPT ); Tue, 1 Mar 2016 21:17:03 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 01 Mar 2016 18:15:45 -0800 Message-ID: <56D64A25.5050700@nvidia.com> Date: Wed, 2 Mar 2016 07:34:21 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , , CC: , , , , Subject: Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation References: <1456750705-13579-1-git-send-email-ldewangan@nvidia.com> <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> <56D63B28.9030502@samsung.com> In-Reply-To: <56D63B28.9030502@samsung.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: > On 29.02.2016 21:58, Laxman Dewangan wrote: >> use macro REGMAP_IRQ_REG from regmap.h to initialise the >> regmap irq table for max77686. > Why? Any benefits? > > I think it is better coding to use macro for member initializations instead of doing it locally and it improves readability. I got the similar comment from Lee's in my MFD patches to use macro for such initialization and I agreed with him. As I was here on this driver, thought to use macro.