From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com. [210.118.77.12]) by gmr-mx.google.com with ESMTPS id y20si2909786pfa.2.2016.03.01.19.46.01 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 01 Mar 2016 19:46:02 -0800 (PST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O3E003LY7SLYE80@mailout2.w1.samsung.com> for rtc-linux@googlegroups.com; Wed, 02 Mar 2016 03:45:57 +0000 (GMT) Subject: [rtc-linux] Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation To: Laxman Dewangan , alexandre.belloni@free-electrons.com, a.zummo@towertech.it References: <1456750705-13579-1-git-send-email-ldewangan@nvidia.com> <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> <56D63B28.9030502@samsung.com> <56D64A25.5050700@nvidia.com> Cc: cw00.choi@samsung.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, javier@osg.samsung.com, rklein@nvidia.com From: Krzysztof Kozlowski Message-id: <56D661F0.9080805@samsung.com> Date: Wed, 02 Mar 2016 12:45:52 +0900 MIME-version: 1.0 In-reply-to: <56D64A25.5050700@nvidia.com> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 02.03.2016 11:04, Laxman Dewangan wrote: > > On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: >> On 29.02.2016 21:58, Laxman Dewangan wrote: >>> use macro REGMAP_IRQ_REG from regmap.h to initialise the >>> regmap irq table for max77686. >> Why? Any benefits? >> >> > I think it is better coding to use macro for member initializations > instead of doing it locally and it improves readability. > > I got the similar comment from Lee's in my MFD patches to use macro for > such initialization and I agreed with him. > > As I was here on this driver, thought to use macro. Sounds good, so this should be written in commit message. BR, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbcCBDqD (ORCPT ); Tue, 1 Mar 2016 22:46:03 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:60369 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbcCBDqB (ORCPT ); Tue, 1 Mar 2016 22:46:01 -0500 X-AuditID: cbfec7f4-f79026d00000418a-59-56d661f5b827 Subject: Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation To: Laxman Dewangan , alexandre.belloni@free-electrons.com, a.zummo@towertech.it References: <1456750705-13579-1-git-send-email-ldewangan@nvidia.com> <1456750705-13579-2-git-send-email-ldewangan@nvidia.com> <56D63B28.9030502@samsung.com> <56D64A25.5050700@nvidia.com> Cc: cw00.choi@samsung.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, javier@osg.samsung.com, rklein@nvidia.com From: Krzysztof Kozlowski Message-id: <56D661F0.9080805@samsung.com> Date: Wed, 02 Mar 2016 12:45:52 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <56D64A25.5050700@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xq7pfE6+FGex5ImKx5OJVdouOa4uZ LK5/ec5q8ebtGiaL1y8MLZbuW81icXnXHDaLZcdXs1rs7+xgdOD0eLLpIqPHnokn2Tx6m9+x eWzpv8vu0bdlFaPH9Hk/mTw+b5ILYI/isklJzcksSy3St0vgymh/cJW9YCNrxYdtM9gaGOex dDFyckgImEhcm7yYFcIWk7hwbz1bFyMXh5DAUkaJF1uXsEI4TxklZk46wg5SJSwQL3G9+Q5Q NweHiECGxMkFnhA1+xglnl8/ywLiMAs0MEqc790I1sAmYCyxefkSNhCbV0BL4vyVNnaQZhYB VYn5LwVAwqICERKHO7vYIUoEJX5Mvgc2nxOofOpOGRCTWUBP4v5FLZAKZgF5ic1r3jJPYBSY haRhFkLVLCRVCxiZVzGKppYmFxQnpeca6hUn5haX5qXrJefnbmKExMGXHYyLj1kdYhTgYFTi 4c34dDVMiDWxrLgy9xCjBAezkggva8y1MCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxES SE8sSc1OTS1ILYLJMnFwSjUwpobmVDo537/uN4GpYdmBjq41QYoZOk/PXztzaLveAuXtPOqN Uz3XndJe82zaW+ksHqH8+8d2LjguxL3tgG1NF5eT2Omtdzk269c1rklxC/nZOGfGCkvT11lH ohMUlkhz92d+CPv9RWNu9pOibRICvR+/Lu6drCyc/DPxiv0tU6nviTo3XgtKKLEUZyQaajEX FScCAGWSm5l/AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.03.2016 11:04, Laxman Dewangan wrote: > > On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: >> On 29.02.2016 21:58, Laxman Dewangan wrote: >>> use macro REGMAP_IRQ_REG from regmap.h to initialise the >>> regmap irq table for max77686. >> Why? Any benefits? >> >> > I think it is better coding to use macro for member initializations > instead of doing it locally and it improves readability. > > I got the similar comment from Lee's in my MFD patches to use macro for > such initialization and I agreed with him. > > As I was here on this driver, thought to use macro. Sounds good, so this should be written in commit message. BR, Krzysztof