From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/135: fix standard error output from _scratch_mkfs
Date: Wed, 2 Mar 2016 13:45:48 +0800 [thread overview]
Message-ID: <56D67E0C.2080301@cn.fujitsu.com> (raw)
In-Reply-To: <20160223032652.GC11419@eguan.usersys.redhat.com>
于 2016/02/23 11:26, Eryu Guan 写道:
> On Tue, Feb 23, 2016 at 09:35:25AM +0800, Xiao Yang wrote:
>> 'mke2fs 1.42.9 (28-Dec-2013)' produces as standard error when
>> we run generic/135 in ext4 file system. This is a regression
>> bug which bring in by commit:
>> 4a5cda8 xfstests: do not unmount tmpfs during remount
>> That patch remove '2>&1', so i bring that back.
> Thanks for the revision! But I noticed that Ted's patch fixed it too,
>
> "common: filter warning messages from mkfs.ext4"
>
> which filters the warnings in _scratch_mkfs_ext4, so that other mkfs
> errors can be noticed in the test. So I think it's a better fix :)
>
> Thanks,
> Eryu
>
Hi
After applying Ted's pacth, 'mke2fs 1.42.9 (28-Dec-2013)' still produces
when we run
generic/135 in ext4 file system. I think that this is standard error
instead of warning .
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>> ---
>> tests/generic/135 | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tests/generic/135 b/tests/generic/135
>> index 52418f6..5aa880d 100755
>> --- a/tests/generic/135
>> +++ b/tests/generic/135
>> @@ -41,7 +41,7 @@ _supported_os Linux IRIX
>>
>> _require_odirect
>> _require_scratch
>> -_scratch_mkfs>/dev/null
>> +_scratch_mkfs&>/dev/null
>> _scratch_mount
>>
>> cd $SCRATCH_MNT
>> --
>> 1.7.1
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2016-03-02 5:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 1:35 [PATCH] generic/135: fix standard error output from _scratch_mkfs Xiao Yang
2016-02-23 3:26 ` Eryu Guan
2016-02-23 3:32 ` Theodore Ts'o
2016-03-02 5:45 ` Xiao Yang [this message]
[not found] <CADVQ27rD6UX7eechDFxke7aE=ty3NJJJKtKGsDR2sCVR5=EP=w@mail.gmail.com>
2016-02-22 9:40 ` Zirong Lang
2016-02-22 10:08 ` Xiao Yang
-- strict thread matches above, loose matches on Subject: below --
2016-02-19 13:46 Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D67E0C.2080301@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.