All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
	"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
	"Krzysztof Hałasa" <khalasa@piap.pl>
Subject: tw686x driver
Date: Wed, 2 Mar 2016 09:32:15 +0100	[thread overview]
Message-ID: <56D6A50F.4060404@xs4all.nl> (raw)

Hi Krzysztof, Ezequiel,

Last Monday I compared the two proposed drivers and I decided to go with Ezequiel's
code. The reasons are that his code has audio support and FIELD_INTERLACED support,
and the reality is that most users (read applications) want full frames instead of
fields. In addition his code was a bit more mature since it had gone through a careful
code review already.

I am obviously unhappy having to choose between two drivers. But the alternative
would be to not have anything merged, and then *everyone* would be unhappy.

Ezequiel, I've asked for two small changes to your v2. Once I have v3 I will make
a pull request.

So lessons learned:

Krzysztof, next time don't wait many months before posting a new version fixing
requested changes.

Ezequiel, next time don't throw away functionality of the original code, instead
just add your own functionality to it.

Regards,

	Hans

             reply	other threads:[~2016-03-02  8:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02  8:32 Hans Verkuil [this message]
2016-03-03  6:51 ` tw686x driver Krzysztof Hałasa
2016-03-03  7:32   ` Hans Verkuil
2016-03-03 12:41     ` Krzysztof Hałasa
2016-03-03 13:37       ` Hans Verkuil
2016-03-03 14:22         ` Krzysztof Hałasa
2016-03-03 14:39           ` Hans Verkuil
2016-03-04  6:11             ` Krzysztof Hałasa
2016-03-04 11:11               ` Hans Verkuil
2016-03-04 12:37                 ` Krzysztof Hałasa
2016-03-04 13:40                   ` Hans Verkuil
2016-03-07  6:41                     ` Krzysztof Hałasa
2016-03-10  7:16                     ` Krzysztof Hałasa
2016-03-10  7:24                       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D6A50F.4060404@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=khalasa@piap.pl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.