From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: o2hb: remove useless force cast
Date: Wed, 2 Mar 2016 17:38:39 +0800 [thread overview]
Message-ID: <56D6B49F.7030408@huawei.com> (raw)
In-Reply-To: <1456905498-22495-1-git-send-email-junxiao.bi@oracle.com>
On 2016/3/2 15:58, Junxiao Bi wrote:
> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Looks good, thanks.
Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
> ---
> fs/ocfs2/cluster/heartbeat.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
> index 8ec85cac894e..023c72d35498 100644
> --- a/fs/ocfs2/cluster/heartbeat.c
> +++ b/fs/ocfs2/cluster/heartbeat.c
> @@ -1315,19 +1315,19 @@ static int o2hb_debug_open(struct inode *inode, struct file *file)
>
> case O2HB_DB_TYPE_REGION_LIVENODES:
> spin_lock(&o2hb_live_lock);
> - reg = (struct o2hb_region *)db->db_data;
> + reg = db->db_data;
> memcpy(map, reg->hr_live_node_bitmap, db->db_size);
> spin_unlock(&o2hb_live_lock);
> break;
>
> case O2HB_DB_TYPE_REGION_NUMBER:
> - reg = (struct o2hb_region *)db->db_data;
> + reg = db->db_data;
> out += snprintf(buf + out, PAGE_SIZE - out, "%d\n",
> reg->hr_region_num);
> goto done;
>
> case O2HB_DB_TYPE_REGION_ELAPSED_TIME:
> - reg = (struct o2hb_region *)db->db_data;
> + reg = db->db_data;
> lts = reg->hr_last_timeout_start;
> /* If 0, it has never been set before */
> if (lts)
> @@ -1336,7 +1336,7 @@ static int o2hb_debug_open(struct inode *inode, struct file *file)
> goto done;
>
> case O2HB_DB_TYPE_REGION_PINNED:
> - reg = (struct o2hb_region *)db->db_data;
> + reg = db->db_data;
> out += snprintf(buf + out, PAGE_SIZE - out, "%u\n",
> !!reg->hr_item_pinned);
> goto done;
>
prev parent reply other threads:[~2016-03-02 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 7:58 [Ocfs2-devel] [PATCH] ocfs2: o2hb: remove useless force cast Junxiao Bi
2016-03-02 9:38 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6B49F.7030408@huawei.com \
--to=joseph.qi@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.