From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Date: Wed, 02 Mar 2016 12:47:35 +0000 Subject: Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL Message-Id: <56D6E0E7.9080204@samsung.com> List-Id: References: <20160302101047.GH5533@mwanda> In-Reply-To: <20160302101047.GH5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Krzysztof Kozlowski , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kukjin Kim Hello, On 2016-03-02 11:10, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') > Signed-off-by: Dan Carpenter Acked-by: Marek Szyprowski > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index b066504..cb57bda 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -1347,8 +1347,8 @@ static int __init exynos_iommu_of_setup(struct device_node *np) > exynos_iommu_init(); > > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); > - if (IS_ERR(pdev)) > - return PTR_ERR(pdev); > + if (!pdev) > + return -ENOMEM; > > /* > * use the first registered sysmmu device for performing > > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL Date: Wed, 02 Mar 2016 13:47:35 +0100 Message-ID: <56D6E0E7.9080204@samsung.com> References: <20160302101047.GH5533@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20160302101047.GH5533@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Carpenter Cc: Krzysztof Kozlowski , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kukjin Kim List-Id: iommu@lists.linux-foundation.org Hello, On 2016-03-02 11:10, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') > Signed-off-by: Dan Carpenter Acked-by: Marek Szyprowski > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index b066504..cb57bda 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -1347,8 +1347,8 @@ static int __init exynos_iommu_of_setup(struct device_node *np) > exynos_iommu_init(); > > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); > - if (IS_ERR(pdev)) > - return PTR_ERR(pdev); > + if (!pdev) > + return -ENOMEM; > > /* > * use the first registered sysmmu device for performing > > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755480AbcCBMrn (ORCPT ); Wed, 2 Mar 2016 07:47:43 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:63096 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752882AbcCBMrl (ORCPT ); Wed, 2 Mar 2016 07:47:41 -0500 X-AuditID: cbfec7f5-f79b16d000005389-33-56d6e0e83d2b Subject: Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL To: Dan Carpenter References: <20160302101047.GH5533@mwanda> Cc: Joerg Roedel , Kukjin Kim , Krzysztof Kozlowski , iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Marek Szyprowski Message-id: <56D6E0E7.9080204@samsung.com> Date: Wed, 02 Mar 2016 13:47:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <20160302101047.GH5533@mwanda> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xK7ovHlwLM5jbpm7x+t90FosF+60t OmdvYLd4/cLQYustaYv+x6+ZLS7vmsNmMeP8PiYHDo8nB+cxeWxa1cnmMfnGckaPj09vsXj0 bVnF6PF5k1wAWxSXTUpqTmZZapG+XQJXxs7LHxkL7rNX/J63kKWBcS1bFyMnh4SAiUTjyTPM ELaYxIV764HiXBxCAksZJXZfnsgK4TxnlHi0fz0TSJWwgIfE/5Z/rCC2iICOxOXOH+xdjBxA RVoSky7KgNQzC/xilDj29BrYBjYBQ4mut11gNi9QzckDW8HmsAioSlw7+RhsjqhAjMTxd+cY IWoEJX5MvscCYnMKaEvcbVoIVs8sYCbx5eVhVghbXmLzmrfMExgFZiFpmYWkbBaSsgWMzKsY RVNLkwuKk9JzjfSKE3OLS/PS9ZLzczcxQoL+6w7GpcesDjEKcDAq8fBmfLoaJsSaWFZcmXuI UYKDWUmE1+jOtTAh3pTEyqrUovz4otKc1OJDjNIcLErivDN3vQ8REkhPLEnNTk0tSC2CyTJx cEo1MLZKrJPhWXlhqpav1efa63sTkp9JVOt5zL5te5jp0wKlo+GK55QZbjNl6bb9tO0uyvvc s7Dtr/wczpV7dy4zvb9bi03rMMuhC1/TJ78993H6oWscLXNN76+selxweuOGHeJbtuh/emfb 8jL1QlLNI57FT88mvjsVsTzrrs1UAaknz+xrLPQ3Ts5RYinOSDTUYi4qTgQAlihHyHYCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2016-03-02 11:10, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') > Signed-off-by: Dan Carpenter Acked-by: Marek Szyprowski > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index b066504..cb57bda 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -1347,8 +1347,8 @@ static int __init exynos_iommu_of_setup(struct device_node *np) > exynos_iommu_init(); > > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); > - if (IS_ERR(pdev)) > - return PTR_ERR(pdev); > + if (!pdev) > + return -ENOMEM; > > /* > * use the first registered sysmmu device for performing > > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland