From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH v7 6/7] drm/i915: refactor duplicate object
 vmap functions (the final rework?)
Date: Wed, 2 Mar 2016 15:40:17 +0000
Message-ID: <56D70961.6080806@intel.com>
References: <1456850039-25856-1-git-send-email-david.s.gordon@intel.com>
 <1456850039-25856-7-git-send-email-david.s.gordon@intel.com>
 <20160302120810.GB25660@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 206C16E8C4
 for <intel-gfx@lists.freedesktop.org>; Wed,  2 Mar 2016 15:40:19 +0000 (UTC)
In-Reply-To: <20160302120810.GB25660@nuc-i3427.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gMDIvMDMvMTYgMTI6MDgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUdWUsIE1hciAwMSwg
MjAxNiBhdCAwNDozMzo1OFBNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gVGhpcyBpcyBl
c3NlbnRpYWxseSBDaHJpcyBXaWxzb24ncyBwYXRjaCBvZiBhIHNpbWlsYXIgbmFtZSwgcmV3b3Jr
ZWQgb24KPj4gdG9wIG9mIEFsZXggRGFpJ3MgcmVjZW50IHBhdGNoOgo+PiB8IGRybS9pOTE1OiBB
ZGQgaTkxNV9nZW1fb2JqZWN0X3ZtYXAgdG8gbWFwIEdFTSBvYmplY3QgdG8gdmlydHVhbCBzcGFj
ZQo+Pgo+PiBDaHJpcycgb3JpZ2luYWwgY29tbWVudGFyeSBzYWlkOgo+PiB8IFdlIG5vdyBoYXZl
IHR3byBpbXBsZW1lbnRhdGlvbnMgZm9yIHZtYXBwaW5nIGEgd2hvbGUgb2JqZWN0LCBvbmUgZm9y
Cj4+IHwgZG1hLWJ1ZiBhbmQgb25lIGZvciB0aGUgcmluZ2J1ZmZlci4gSWYgd2UgY291cGxlIHRo
ZSB2bWFwcGluZyBpbnRvCj4+IHwgdGhlIG9iai0+cGFnZXMgbGlmZXRpbWUsIHRoZW4gd2UgY2Fu
IHJldXNlIGFuIG9iai0+dm1hcHBpbmcgZm9yIGJvdGgKPj4gfCBhbmQgYXQgdGhlIHNhbWUgdGlt
ZSBjb3VwbGUgaXQgaW50byB0aGUgc2hyaW5rZXIuCj4+IHwKPj4gfCB2MjogTWFyayB0aGUgZmFp
bGFibGUga21hbGxvYygpIGFzIF9fR0ZQX05PV0FSTiAodnN5cmphbGEpCj4+IHwgdjM6IENhbGwg
dW5waW5fdm1hcCBmcm9tIHRoZSByaWdodCBkbWFidWYgdW5tYXBwZXIKPj4KPj4gdjQ6IHJlaW1w
bGVtZW50cyB0aGUgc2FtZSBmdW5jdGlvbmFsaXR5LCBidXQgbm93IGFzIHdyYXBwZXJzIHJvdW5k
IHRoZQo+PiAgICAgIHJlY2VudGx5LWludHJvZHVjZWQgaTkxNV9nZW1fb2JqZWN0X3ZtYXBfcmFu
Z2UoKSBmcm9tIEFsZXgncyBwYXRjaAo+PiAgICAgIG1lbnRpb25lZCBhYm92ZS4KPj4KPj4gdjU6
IHNlcGFyYXRlZCBmcm9tIHR3byBtaW5vciBidXQgdW5yZWxhdGVkIGNoYW5nZXMgW1R2cnRrbyBV
cnN1bGluXTsKPj4gICAgICB0aGlzIGlzIHRoZSB0aGlyZCBhbmQgbW9zdCBzdWJzdGFudGlhbCBw
b3J0aW9uLgo+Pgo+PiAgICAgIERlY2lkZWQgbm90IHRvIGhvbGQgb250byB2bWFwcGluZ3MgYWZ0
ZXIgdGhlIHBpbiBjb3VudCBnb2VzIHRvIHplcm8uCj4+ICAgICAgVGhpcyBtYXkgcmVkdWNlIHRo
ZSBiZW5lZml0IG9mIENocmlzJyBzY2hlbWUgYSBiaXQsIGJ1dCBkb2VzIGF2b2lkCj4+ICAgICAg
YW55IGluY3JlYXNlZCByaXNrIG9mIGV4aGF1c3Rpbmcga2VybmVsIHZtYXAgc3BhY2Ugb24gMzIt
Yml0IGtlcm5lbHMKPj4gICAgICBbVHZydGtvIFVyc3VsaW5dLiBQb3RlbnRpYWxseSwgdGhlIHZ1
bm1hcCgpIGNvdWxkIGJlIGRlZmVycmVkIHVudGlsCj4+ICAgICAgdGhlIHB1dF9wYWdlcygpIHN0
YWdlIGlmIGEgc3VpdGFibGUgbm90aWZpZXIgd2VyZSB3cml0dGVuLCBidXQgd2UncmUKPj4gICAg
ICBub3QgZG9pbmcgdGhhdCBoZXJlLiBOb25ldGhlbGVzcywgdGhlIHNpbXBsaWZpY2F0aW9uIG9m
IGJvdGggZG1hYnVmCj4+ICAgICAgYW5kIHJpbmdidWZmZXIgY29kZSBtYWtlcyBpdCB3b3J0aHdo
aWxlIGluIGl0cyBvd24gcmlnaHQuCj4+Cj4+IHY2OiBjaGFuZ2UgQlVHX09OKCkgdG8gV0FSTl9P
TigpLiBbVHZydGtvIFVyc3VsaW5dCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxk
YXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+IFJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8
dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp
cy13aWxzb24uY28udWs+Cj4+IENjOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPj4gLS0t
Cj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgIHwgMjIgKysrKysr
KysrKysrKystLS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICAg
ICB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZ2VtX2RtYWJ1Zi5jICB8IDM2ICsrKystLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyB8ICA5
ICsrKystLS0tCj4+ICAgNCBmaWxlcyBjaGFuZ2VkLCA2NSBpbnNlcnRpb25zKCspLCA0MSBkZWxl
dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2
LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IGluZGV4IGIzYWUxOTEuLmYx
YWQzYjMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBAQCAtMjE3MiwxMCArMjE3
Miw3IEBAIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0IHsKPj4gICAJCXN0cnVjdCBzY2F0dGVy
bGlzdCAqc2c7Cj4+ICAgCQlpbnQgbGFzdDsKPj4gICAJfSBnZXRfcGFnZTsKPj4gLQo+PiAtCS8q
IHByaW1lIGRtYS1idWYgc3VwcG9ydCAqLwo+PiAtCXZvaWQgKmRtYV9idWZfdm1hcHBpbmc7Cj4+
IC0JaW50IHZtYXBwaW5nX2NvdW50Owo+PiArCXZvaWQgKnZtYXBwaW5nOwo+Pgo+PiAgIAkvKiog
QnJlYWRjcnVtYiBvZiBsYXN0IHJlbmRlcmluZyB0byB0aGUgYnVmZmVyLgo+PiAgIAkgKiBUaGVy
ZSBjYW4gb25seSBiZSBvbmUgd3JpdGVyLCBidXQgd2UgYWxsb3cgZm9yIG11bHRpcGxlIHJlYWRl
cnMuCj4+IEBAIC0yOTgwLDcgKzI5NzcsMjIgQEAgc3RhdGljIGlubGluZSB2b2lkIGk5MTVfZ2Vt
X29iamVjdF9waW5fcGFnZXMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPj4gICBz
dGF0aWMgaW5saW5lIHZvaWQgaTkxNV9nZW1fb2JqZWN0X3VucGluX3BhZ2VzKHN0cnVjdCBkcm1f
aTkxNV9nZW1fb2JqZWN0ICpvYmopCj4+ICAgewo+PiAgIAlCVUdfT04ob2JqLT5wYWdlc19waW5f
Y291bnQgPT0gMCk7Cj4+IC0Jb2JqLT5wYWdlc19waW5fY291bnQtLTsKPj4gKwlpZiAoLS1vYmot
PnBhZ2VzX3Bpbl9jb3VudCA9PSAwICYmIG9iai0+dm1hcHBpbmcpIHsKPj4gKwkJLyoKPj4gKwkJ
ICogUmVsZWFzaW5nIHRoZSB2bWFwcGluZyBoZXJlIG1heSB5aWVsZCBsZXNzIGJlbmVmaXQgdGhh
bgo+PiArCQkgKiBpZiB3ZSBrZXB0IGl0IHVudGlsIHB1dF9wYWdlcygpLCBidXQgb24gdGhlIG90
aGVyIGhhbmQKPgo+IFlpZWxkcyBubyBiZW5lZml0LiBNYWtlcyB0aGUgcGF0Y2ggcG9pbnRsZXNz
Lgo+IFBsdXMgdGhlcmUgaXMgYWxzbyBwcmVzc3VyZSB0byBlbmFibGUgV0Mgdm1hcHMuCj4gLUNo
cmlzCgpUaGUgcGF0Y2ggaXMgbm90IHBvaW50bGVzcyAtLSBhdCB0aGUgdmVyeSBsZWFzdCwgaXQ6
CisgcmVkdWNlcyB0aGUgc2l6ZSBvZiAic3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QiIChPSywg
b25seSBieSA0IGJ5dGVzKQorIHJlcGxhY2VzIHNwZWNpYWwtZnVuY3Rpb24gY29kZSBmb3IgZG1h
YnVmcyB3aXRoIG1vcmUgZ2VuZXJpYyBjb2RlIHRoYXQgCmNhbiBiZSByZXVzZWQgZm9yIG90aGVy
IG9iamVjdHMgKGZvciBub3csIHJpbmdidWZmZXJzOyBuZXh0IEd1Qy1zaGFyZWQgCm9iamVjdHMg
LS0gc2VlIEFsZXgncyBwYXRjaCAiZHJtL2k5MTUvZ3VjOiBTaW1wbGlmeSBjb2RlIGJ5IGtlZXBp
bmcgdm1hcCAKb2YgZ3VjX2NsaWVudCBvYmplY3QiIHdoaWNoIHdpbGwgZWxpbWluYXRlIGxvdCBv
ZiBzaG9ydC10ZXJtIAprbWFwX2F0b21pY3Mgd2l0aCBwZXJzaXN0ZW50IGttYXBzKS4KKyBwcm92
aWRlcyBhIHNob3J0aGFuZCBmb3IgdGhlIHNlcXVlbmNlIG9mIHsgZ2V0X3BhZ2VzKCksIHBpbl9w
YWdlcygpLCAKdm1hcCgpIH0gc28gd2UgZG9uJ3QgaGF2ZSB0byBvcGVuLWNvZGUgaXQgKGFuZCBk
ZWFsIHdpdGggYWxsIHRoZSBlcnJvciAKcGF0aHMpIGluIHNldmVyYWwgZGlmZmVyZW50IHBsYWNl
cwoKVGh1cyB0aGVyZSBpcyBhbiBlbmdpbmVlcmluZyBiZW5lZml0IGV2ZW4gaWYgdGhpcyB2ZXJz
aW9uIGRvZXNuJ3QgCnByb3ZpZGUgYW55IHBlcmZvcm1hbmNlIGJlbmVmaXQuIEFuZCBpZiwgYXMg
dGhlIG5leHQgc3RlcCwgeW91IHdhbnQgdG8gCmV4dGVuZCB0aGUgdm1hcCBsaWZldGltZSwgeW91
IGp1c3QgaGF2ZSB0byByZW1vdmUgdGhvc2UgZmV3IGxpbmVzIGluIAppOTE1X2dlbV9vYmplY3Rf
dW5waW5fcGFnZXMoKSBhbmQgaW5jb3Jwb3JhdGUgdGhlIG5vdGlmaWVyIHRoYXQgeW91IApwcm90
b3R5cGVkIGVhcmxpZXIgLS0gaWYgaXQgYWN0dWFsbHkgcHJvdmlkZXMgYW55IHBlcmZvcm1hbmNl
IGJvb3N0LgoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs
LWdmeAo=