All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Sergei Lebedev" <sergei.a.lebedev@gmail.com>
Cc: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xen.org
Subject: Re: Zero-sized reads from XenBus block
Date: Wed, 2 Mar 2016 12:14:33 -0500	[thread overview]
Message-ID: <56D71F79.5090106@oracle.com> (raw)
In-Reply-To: <56D7166D.9080203@citrix.com>

On 03/02/2016 11:35 AM, Roger Pau Monné wrote:
> El 2/3/16 a les 17:13, Wei Liu ha escrit:
>> CC Linux kernel and FreeBSD maintainers.
>>
>> On Wed, Mar 02, 2016 at 12:29:26AM +0300, Sergei Lebedev wrote:
>>> Hi list,
>>>
>>> I’m not sure if this is the expected behaviour, but it seems zero-sized reads from /dev/xen/xenbus block. Here’s sample code in Python
>>>
>>>      import os
>>>      
>>>      fd = os.open("/dev/xen/xenbus", os.O_RDWR)
>>>      os.read(fd, 0)  # Blocks.
>>>
>>> The issue is not language-specific, similar code in C blocks as well.
> I've tested your code on FreeBSD (after replacing /dev/xen/xenbus with
> /dev/xen/xenstore), and it doesn't block there. AFAICT this is because
> 0-size reads never get to the device "read" routine on FreeBSD, or else
> it would block.

This is how xenbus driver is designed --- it always blocks until 
something is written there.

It should indeed return zero right away but I wonder whether someone 
might count on current implementation (in the toolstack or elsewhere). 
Based on FreeBSD behavior I'd think this shouldn't be the case.


-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-03-02 17:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 21:29 Zero-sized reads from XenBus block Sergei Lebedev
2016-03-02 16:13 ` Wei Liu
2016-03-02 16:35   ` Roger Pau Monné
2016-03-02 17:14     ` Boris Ostrovsky [this message]
2016-03-03 17:03       ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D71F79.5090106@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=sergei.a.lebedev@gmail.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.