From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Longnecker Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Date: Wed, 2 Mar 2016 16:08:33 -0800 Message-ID: <56D78081.6050106@nvidia.com> References: <1456739480-3304-1-git-send-email-wni@nvidia.com> <56D698FE.7070706@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56D698FE.7070706-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wei Ni , thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mikko.perttunen-/1wQRMveznE@public.gmane.org Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/01/2016 11:40 PM, Wei Ni wrote: > >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > >index 74ea5765938b..136975220c92 100644 > >--- a/drivers/thermal/tegra_soctherm.c > >+++ b/drivers/thermal/tegra_soctherm.c > >@@ -57,7 +57,7 @@ > > #define READBACK_VALUE_MASK 0xff00 > > #define READBACK_VALUE_SHIFT 8 > > #define READBACK_ADD_HALF BIT(7) > >-#define READBACK_NEGATE BIT(1) > >+#define READBACK_NEGATE BIT(0) I confirm that this change is technically correct. It fixes a bug. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755000AbcCCAIj (ORCPT ); Wed, 2 Mar 2016 19:08:39 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:3576 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753982AbcCCAIh (ORCPT ); Wed, 2 Mar 2016 19:08:37 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 02 Mar 2016 16:07:24 -0800 Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature To: Wei Ni , , , References: <1456739480-3304-1-git-send-email-wni@nvidia.com> <56D698FE.7070706@nvidia.com> CC: , , From: Matt Longnecker Message-ID: <56D78081.6050106@nvidia.com> Date: Wed, 2 Mar 2016 16:08:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56D698FE.7070706@nvidia.com> X-Originating-IP: [10.2.167.193] X-ClientProxiedBy: HQMAIL102.nvidia.com (172.18.146.10) To HQMAIL102.nvidia.com (172.18.146.10) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2016 11:40 PM, Wei Ni wrote: > >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > >index 74ea5765938b..136975220c92 100644 > >--- a/drivers/thermal/tegra_soctherm.c > >+++ b/drivers/thermal/tegra_soctherm.c > >@@ -57,7 +57,7 @@ > > #define READBACK_VALUE_MASK 0xff00 > > #define READBACK_VALUE_SHIFT 8 > > #define READBACK_ADD_HALF BIT(7) > >-#define READBACK_NEGATE BIT(1) > >+#define READBACK_NEGATE BIT(0) I confirm that this change is technically correct. It fixes a bug.