Re: [PATCH nfs-utils v2] statd: Don't unregister statd service on failing to execute callout

[Steve Dickson <SteveD@redhat.com>]

Hey,

On 03/02/2016 07:20 PM, Toshiaki Makita wrote:
> Hi Steve,
> 
> On 2016/02/16 9:36, Toshiaki Makita wrote:
>> statd calls atexit(statd_unregister) to unregister statd service on exit,
>> which actually has a side-effect that ha_callout() unregisters statd
>> service even when the child callout process exits on execl() failure.
>>
>> Certain clustering software's deployment script adds -H option with its
>> specified file non-existent, when it is configured not to use callout.
>> In other words, -H seems to be used no matter if callout is needed or not,
>> but when callout is unnecessary, the specified callout program is not
>> deployed.
>> This causes statd not to work once a lock is requested by its NFS client,
>> as execl() in ha_callout() results in ENOENT and exit() of the child
>> process calls exit-handler statd_unregister(). Eventually, the NFS client
>> gets stuck with messages "lockd: cannot monitor xxx" on the NFS server.
>>
>> Also, execl() could fail for other reasons like ENFILE or EIO as well.
>>
>> A forked child must not unregister the statd RPC server, so use
>> _exit(), which does not call any exit-handlers, instead of exit().
>>
>> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
>> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> 
> Would you tell me the status of this patch?
Its on my too do list.... I've been traveling but have every
intention on catching up asap... 

steved.

> 
> Regards,
> Toshiaki Makita
> 
>