From: Shunqian Zheng <zhengsq@rock-chips.com>
To: John Lin <john.lin@realtek.com>, Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Bard Liao <bardliao@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Flove <flove@realtek.com>
Subject: Re: [PATCH] ASoC: rt5616: add kcontrol for headphone channel switch
Date: Thu, 03 Mar 2016 15:21:26 +0800 [thread overview]
Message-ID: <56D7E5F6.7010605@rock-chips.com> (raw)
In-Reply-To: <14AE6189BDA733429BF8455FEEF632980110FFD1@RTITMBSV02.realtek.com.tw>
John,
On 2016年03月03日 10:45, John Lin wrote:
>> -----Original Message-----
>> From: Mark Brown [mailto:broonie@kernel.org]
>> Sent: Wednesday, March 02, 2016 6:36 PM
>> To: John Lin
>> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Bard Liao; Flove;
>> Oder Chiou; zhengsq@rock-chips.com
>> Subject: Re: [PATCH] ASoC: rt5616: add kcontrol for headphone channel switch
>>
>> On Wed, Mar 02, 2016 at 05:18:40PM +0800, John Lin wrote:
>>
>>> SOC_DOUBLE("HP Playback Switch", RT5616_HP_VOL,
>>> RT5616_L_MUTE_SFT, RT5616_R_MUTE_SFT, 1, 1),
>>> + SOC_DOUBLE("HP Channel Switch", RT5616_HP_VOL,
>>> + RT5616_VOL_L_SFT, RT5616_VOL_R_SFT, 1, 1),
>> What does "Channel Switch" mean? It looks like this is a mute control
>> in which case it shoiuld be HP Playback Switch or similar like other
>> mute controls.
>>
> Yes, It is another mute control that is missing on current driver.
> This mute control is for headphone volume mute. Is it OK to rename it to
> 'Headphone Volume Playback Switch'?
In rt5616.c, there is another control named "OUT Channel Switch".
You may want to rename it too.
- Shunqian
>
>
>> ------Please consider the environment before printing this e-mail.
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2016-03-03 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 9:18 [PATCH] ASoC: rt5616: add kcontrol for headphone channel switch John Lin
2016-03-02 10:35 ` Mark Brown
2016-03-03 2:45 ` John Lin
2016-03-03 7:21 ` Shunqian Zheng [this message]
2016-03-05 3:51 ` Mark Brown
2016-03-07 2:35 ` John Lin
2016-03-07 2:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D7E5F6.7010605@rock-chips.com \
--to=zhengsq@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.