From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45611)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1abNdR-0006Sc-18
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 02:25:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1abNdN-0004fS-Pa
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 02:25:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33105)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1abNdN-0004fO-K2
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 02:25:17 -0500
References: <1456748635-1912-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1456748635-1912-2-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<56D685FE.6030207@redhat.com> <56D6955E.5090102@cn.fujitsu.com>
	<56D7DE4A.5000101@redhat.com> <56D7E5C5.2040707@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56D7E6CB.2060500@redhat.com>
Date: Thu, 3 Mar 2016 15:24:59 +0800
MIME-Version: 1.0
In-Reply-To: <56D7E5C5.2040707@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 1/3] net/filter-traffic: add
 filter-traffic.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, "eddie.dong" <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Yang Hongyang <hongyang.yang@easystack.cn>



On 03/03/2016 03:20 PM, Zhang Chen wrote:
>
>
> On 03/03/2016 02:48 PM, Jason Wang wrote:
>>
>> On 03/02/2016 03:25 PM, Zhang Chen wrote:
>>>
>>> On 03/02/2016 02:19 PM, Jason Wang wrote:
>>>> On 02/29/2016 08:23 PM, Zhang Chen wrote:
>>>>> We can reuse filter-traffic by filter-mirror,
>>>>> filter-redirector and so on.
>>>> I think we could share more than this. E.g just use filter-mirror.c to
>>>> implement both mirror and redirector.
>>> OK, should we change the name to filter-mirror? like filter-traffic?
>>> and add redirect=on/off
>>>
>>> -object
>>> filter-mirror,id=qtest-f0,netdev=qtest-bn0,queue=tx,indev=redirect0,redirect=on,outdev=mirror0
>>>
>>>
>> I think we'd better use another type for this.
>>
>
> What is the "another type " ?
> please tell me the detail for this.

E.g. register another type like "filter-redirector" in reister_types()
of filter-mirror.c.

Thanks

>
> Thanks
> zhangchen
>
>>
>>
>