All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, rkrcmar@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 3/4] arm64: fix printf format warnings
Date: Thu, 3 Mar 2016 10:41:30 +0100	[thread overview]
Message-ID: <56D806CA.8030005@redhat.com> (raw)
In-Reply-To: <1456942034-21005-4-git-send-email-drjones@redhat.com>

On 02.03.2016 19:07, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  lib/arm64/processor.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/arm64/processor.c b/lib/arm64/processor.c
> index c553390c969ea..deeab4ec9c8ac 100644
> --- a/lib/arm64/processor.c
> +++ b/lib/arm64/processor.c
> @@ -66,12 +66,12 @@ void show_regs(struct pt_regs *regs)
>  {
>  	int i;
>  
> -	printf("pc : [<%016llx>] lr : [<%016llx>] pstate: %08llx\n",
> +	printf("pc : [<%016lx>] lr : [<%016lx>] pstate: %08lx\n",
>  			regs->pc, regs->regs[30], regs->pstate);
> -	printf("sp : %016llx\n", regs->sp);
> +	printf("sp : %016lx\n", regs->sp);
>  
>  	for (i = 29; i >= 0; --i) {
> -		printf("x%-2d: %016llx ", i, regs->regs[i]);
> +		printf("x%-2d: %016lx ", i, regs->regs[i]);
>  		if (i % 2 == 0)
>  			printf("\n");
>  	}
> @@ -121,7 +121,7 @@ static void bad_exception(enum vector v, struct pt_regs *regs,
>  	}
>  
>  	printf("Vector: %d (%s)\n", v, vector_names[v]);
> -	printf("ESR_EL1: %8s%08lx, ec=0x%x (%s)\n", "", esr, ec, ec_names[ec]);
> +	printf("ESR_EL1: %8s%08x, ec=0x%x (%s)\n", "", esr, ec, ec_names[ec]);
>  	printf("FAR_EL1: %016lx (%svalid)\n", far, far_valid ? "" : "not ");
>  	printf("Exception frame registers:\n");
>  	show_regs(regs);

Reviewed-by: Thomas Huth <thuth@redhat.com>


  reply	other threads:[~2016-03-03  9:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 18:07 [kvm-unit-tests PATCH v2 0/4] add fmt warnings to printf, and fix bad uses Andrew Jones
2016-03-02 18:07 ` [kvm-unit-tests PATCH v2 1/4] lib: *printf: warn on format/arg mismatch Andrew Jones
2016-03-02 18:07 ` [kvm-unit-tests PATCH v2 2/4] lib/alloc: fix format warnings, add/use PRIx64 Andrew Jones
2016-03-03  9:28   ` Thomas Huth
2016-03-03 12:22     ` Andrew Jones
2016-03-03 12:36       ` Paolo Bonzini
2016-03-02 18:07 ` [kvm-unit-tests PATCH v2 3/4] arm64: fix printf format warnings Andrew Jones
2016-03-03  9:41   ` Thomas Huth [this message]
2016-03-02 18:07 ` [kvm-unit-tests PATCH v2 4/4] x86: " Andrew Jones
2016-03-03  9:57   ` Thomas Huth
2016-03-03 12:26     ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D806CA.8030005@redhat.com \
    --to=thuth@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.