From mboxrd@z Thu Jan 1 00:00:00 1970 From: Majd Dibbiny Subject: Re: [PATCH 0/2] User-index fixes Date: Thu, 3 Mar 2016 11:57:49 +0200 Message-ID: <56D80A9D.6030507@mellanox.com> References: <1455467752-3170-1-git-send-email-matanb@mellanox.com> <56C49D8C.2000605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56C49D8C.2000605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford , Matan Barak Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Or Gerlitz , Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On 17/2/2016 6:19 PM, Doug Ledford wrote: > On 02/14/2016 11:35 AM, Matan Barak wrote: >> From: Majd Dibbiny >> >> Hi Doug, >> >> This series fixes two issues introduced in 4.5 after applying my >> series "Raw Packet QP user-space support for mlx5". >> >> SRQs don't use user-index, therefore the user shouldn't pass it and the >> kernel shouldn't verify. The first patch fixes this by avoiding >> user-index verification for non-xrc srqs. >> >> The mlx5_ib driver fails libraries that support user-index but don't >> pass it. It relies on the input length of the vendor specific part to >> determine whether the user-space supports user-index. >> >> >> In Legacy verbs, the given vendor specific part input length is given >> including struct ib_uverbs_cmd_hdr. In contrast, extended commands >> pass the same length exluding the header size. >> The vendor driver doesn't know whether the command is a legacy >> command or an extended command. Thus, we need to modify IB/core >> in order to pass a consistent size. The second patch fixes the input >> length in the IB/core and the wrong usage in the mlx5_ib. >> >> We verified that other vendors don't use the inlen parameter and thus >> won't break by this change. >> >> Thanks, >> Majd and Matan >> >> >> Majd Dibbiny (2): >> IB/mlx5: Avoid using user-index for SRQs >> IB/{core, mlx5}: Fix input len in vendor specific part of >> create_qp/srq cmd >> >> drivers/infiniband/core/uverbs_cmd.c | 9 +++++--- >> drivers/infiniband/hw/mlx5/srq.c | 41 +++++++++++++++++++----------------- >> 2 files changed, 28 insertions(+), 22 deletions(-) >> > These went in already in case you missed it. Thanks. Hi Doug, I can't see those patches in your git repositories. Where were they applied to? Thanks > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html