From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH v2 4/4] x86: fix printf format warnings Date: Thu, 3 Mar 2016 10:57:54 +0100 Message-ID: <56D80AA2.2030002@redhat.com> References: <1456942034-21005-1-git-send-email-drjones@redhat.com> <1456942034-21005-5-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: pbonzini@redhat.com, rkrcmar@redhat.com To: Andrew Jones , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60875 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbcCCJ55 (ORCPT ); Thu, 3 Mar 2016 04:57:57 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 3739585541 for ; Thu, 3 Mar 2016 09:57:57 +0000 (UTC) In-Reply-To: <1456942034-21005-5-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02.03.2016 19:07, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > lib/x86/desc.c | 6 +++--- > lib/x86/vm.c | 6 +++--- > x86/access.c | 4 ++-- > x86/eventinj.c | 8 ++++---- > x86/kvmclock.c | 2 +- > x86/kvmclock_test.c | 6 +++--- > x86/msr.c | 3 ++- > x86/s3.c | 6 +++--- > x86/svm.c | 12 ++++++------ > x86/taskswitch.c | 2 +- > x86/taskswitch2.c | 4 ++-- > x86/tsc.c | 4 ++-- > x86/tscdeadline_latency.c | 2 +- > x86/vmx.c | 18 +++++++++--------- > x86/vmx_tests.c | 20 ++++++++++---------- > x86/xsave.c | 2 +- > 16 files changed, 53 insertions(+), 52 deletions(-) > > diff --git a/lib/x86/desc.c b/lib/x86/desc.c > index 1a80c01283853..12bcb57a42d1d 100644 > --- a/lib/x86/desc.c > +++ b/lib/x86/desc.c > @@ -53,7 +53,7 @@ static void check_exception_table(struct ex_regs *regs) > return; > } > } > - printf("unhandled exception %d\n", regs->vector); > + printf("unhandled exception %lu\n", regs->vector); > exit(7); > } > > @@ -75,9 +75,9 @@ void do_handle_exception(struct ex_regs *regs) > exception_handlers[regs->vector](regs); > return; > } > - printf("unhandled cpu exception %d\n", regs->vector); > + printf("unhandled cpu exception %ld\n", regs->vector); Nit: That could be %lu here, too, as far as I can see. Anyway, the remaining parts of the patch look fine, and it's really a very small nit, so: Reviewed-by: Thomas Huth