From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH v2 2/4] lib/alloc: fix format warnings, add/use PRIx64 Date: Thu, 3 Mar 2016 13:36:56 +0100 Message-ID: <56D82FE8.7090003@redhat.com> References: <1456942034-21005-1-git-send-email-drjones@redhat.com> <1456942034-21005-3-git-send-email-drjones@redhat.com> <56D803AF.4050508@redhat.com> <20160303122202.ki36zyfyucqxdkkp@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, rkrcmar@redhat.com To: Andrew Jones , Thomas Huth Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbcCCMhA (ORCPT ); Thu, 3 Mar 2016 07:37:00 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3FF0685541 for ; Thu, 3 Mar 2016 12:37:00 +0000 (UTC) In-Reply-To: <20160303122202.ki36zyfyucqxdkkp@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 03/03/2016 13:22, Andrew Jones wrote: >> > So as far as I can see, the related variables (align_min et al.) are of >> > type phys_addr_t. And phys_addr_t is defined like this: >> > >> > #ifdef PHYS32 >> > typedef u32 phys_addr_t; >> > #else >> > typedef u64 phys_addr_t; >> > #endif > Oh yeah... It's tempting to just blow that away Just blow it away. Both aarch32 and x86-32 support 64-bit physical address space through PAE and LPAE. You can do it on top of v3, but remember to clean up the casts. Paolo