All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, rkrcmar@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 0/4] add fmt warnings to printf, and fix bad uses
Date: Thu, 3 Mar 2016 13:37:57 +0100	[thread overview]
Message-ID: <56D83025.3000407@redhat.com> (raw)
In-Reply-To: <1457008388-12749-1-git-send-email-drjones@redhat.com>



On 03/03/2016 13:33, Andrew Jones wrote:
> Thomas suggested adding __attribute__((format(printf, i, j))) to
> our *printf functions. So I did. And then fixed all the warnings...
> 
> v3:
>  * another lu in desc.c [Thomas]
>  * handle phys_addr_t := u32 in alloc.c [Thomas]
> v2:
>  * don't use the temporary _f() macro the attributes [Paolo]
>  * changes from Thomas' review comments
>     - desc.c: use %lu instead of %ld
>     - msr.c: don't screw up the int:int output of a longlong
>     - taskswitch2.c: remove useless (ulong*) casts
> 
> 
> Andrew Jones (4):
>   lib: *printf: warn on format/arg mismatch
>   lib/alloc: fix format warnings, add/use PRIx64
>   arm64: fix printf format warnings
>   x86: fix printf format warnings
> 
>  lib/alloc.c               | 25 ++++++++++++++-----------
>  lib/arm64/processor.c     |  8 ++++----
>  lib/libcflat.h            | 26 +++++++++++++++++++++-----
>  lib/x86/desc.c            |  6 +++---
>  lib/x86/vm.c              |  6 +++---
>  x86/access.c              |  4 ++--
>  x86/eventinj.c            |  8 ++++----
>  x86/kvmclock.c            |  2 +-
>  x86/kvmclock_test.c       |  6 +++---
>  x86/msr.c                 |  3 ++-
>  x86/s3.c                  |  6 +++---
>  x86/svm.c                 | 12 ++++++------
>  x86/taskswitch.c          |  2 +-
>  x86/taskswitch2.c         |  4 ++--
>  x86/tsc.c                 |  4 ++--
>  x86/tscdeadline_latency.c |  2 +-
>  x86/vmx.c                 | 18 +++++++++---------
>  x86/vmx_tests.c           | 20 ++++++++++----------
>  x86/xsave.c               |  2 +-
>  19 files changed, 92 insertions(+), 72 deletions(-)
> 

Applied, thanks.

Paolo

      parent reply	other threads:[~2016-03-03 12:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 12:33 [kvm-unit-tests PATCH v3 0/4] add fmt warnings to printf, and fix bad uses Andrew Jones
2016-03-03 12:33 ` [kvm-unit-tests PATCH v3 1/4] lib: *printf: warn on format/arg mismatch Andrew Jones
2016-03-03 12:33 ` [kvm-unit-tests PATCH v3 2/4] lib/alloc: fix format warnings, add/use PRIx64 Andrew Jones
2016-03-03 12:38   ` Thomas Huth
2016-03-03 12:33 ` [kvm-unit-tests PATCH v3 3/4] arm64: fix printf format warnings Andrew Jones
2016-03-03 12:33 ` [kvm-unit-tests PATCH v3 4/4] x86: " Andrew Jones
2016-03-03 12:37 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D83025.3000407@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.