From: Paolo Bonzini <pbonzini@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] trivial: add "check" keyword description
Date: Thu, 3 Mar 2016 14:51:40 +0100 [thread overview]
Message-ID: <56D8416C.4070206@redhat.com> (raw)
In-Reply-To: <1457012871-7060-1-git-send-email-lvivier@redhat.com>
On 03/03/2016 14:47, Laurent Vivier wrote:
> x86/unittests.cfg uses a keyword which is not described in the header.
> "check" is used and described in scripts/runtime.bash,
> so add the comment in the header of all the unittests.cfg.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> arm/unittests.cfg | 4 ++++
> powerpc/unittests.cfg | 4 ++++
> x86/unittests.cfg | 4 ++++
> 3 files changed, 12 insertions(+)
Applied (after resolving conflicts), thanks.
Paolo
> diff --git a/arm/unittests.cfg b/arm/unittests.cfg
> index 5e26da1..9465c69 100644
> --- a/arm/unittests.cfg
> +++ b/arm/unittests.cfg
> @@ -8,6 +8,10 @@
> # groups = group1 group2 # Used to identify test cases with run_tests -g ...
> # accel = kvm|tcg # Optionally specify if test must run with kvm or tcg.
> # # If not specified, then kvm will be used when available.
> +# check = <path>=<value> # check a file for a particular value before running
> +# # a test. The check line can contain multiple files
> +# # to check separated by a space but each check
> +# # parameter needs to be of the form <path>=<value>
>
> #
> # Test that the configured number of processors (smp = <num>), and
> diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
> index 0666922..02b21c7 100644
> --- a/powerpc/unittests.cfg
> +++ b/powerpc/unittests.cfg
> @@ -16,6 +16,10 @@
> # # kvm or tcg. If not specified, then kvm will
> # # be used when available.
> # timeout = <duration> # Optionally specify a timeout.
> +# check = <path>=<value> # check a file for a particular value before running
> +# # a test. The check line can contain multiple files
> +# # to check separated by a space but each check
> +# # parameter needs to be of the form <path>=<value>
> ##############################################################################
>
> #
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index 99eff26..3155eca 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -6,6 +6,10 @@
> # extra_params = -cpu qemu64,+x2apic # Additional parameters used
> # arch = i386/x86_64 # Only if the test case works only on one of them
> # groups = group1 group2 # Used to identify test cases with run_tests -g ...
> +# check = <path>=<value> # check a file for a particular value before running
> +# # a test. The check line can contain multiple files
> +# # to check separated by a space but each check
> +# # parameter needs to be of the form <path>=<value>
>
> [apic]
> file = apic.flat
>
prev parent reply other threads:[~2016-03-03 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 13:47 [kvm-unit-tests PATCH] trivial: add "check" keyword description Laurent Vivier
2016-03-03 13:51 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8416C.4070206@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.