From: Adrian Hunter <adrian.hunter@intel.com>
To: Lucas Stach <dev@lynxeye.de>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: tegra: properly disable card clock
Date: Thu, 3 Mar 2016 16:06:56 +0200 [thread overview]
Message-ID: <56D84500.1030807@intel.com> (raw)
In-Reply-To: <1456779385-18996-1-git-send-email-dev@lynxeye.de>
On 29/02/16 22:56, Lucas Stach wrote:
> The new code to do the clock rate setting externally to the SDMMC
> module has a shortcut to not propagate changes with a 0 rate to
> the CAR by simply bailing out. This breaks proper cutting of the
> card clock. Fix it by directly calling the correct sdhci function.
>
> Fixes: a8e326a911d3 "mmc: tegra: implement module external clock change"
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 212d51f..46a6bd1 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -194,7 +194,7 @@ static void tegra_sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
> unsigned long host_clk;
>
> if (!clock)
> - return;
> + return sdhci_set_clock(host, clock);;
>
> host_clk = tegra_host->ddr_signaling ? clock * 2 : clock;
> clk_set_rate(pltfm_host->clk, host_clk);
>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
next prev parent reply other threads:[~2016-03-03 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 20:56 [PATCH 1/2] mmc: tegra: properly disable card clock Lucas Stach
[not found] ` <1456779385-18996-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2016-02-29 20:56 ` [PATCH 2/2] mmc: tegra: implement memcomp pad calibration Lucas Stach
2016-03-04 13:02 ` Adrian Hunter
2016-03-16 11:37 ` Ulf Hansson
2016-03-16 15:04 ` Ulf Hansson
2016-03-03 14:06 ` Adrian Hunter [this message]
2016-03-04 9:41 ` [PATCH 1/2] mmc: tegra: properly disable card clock Ulf Hansson
[not found] ` <CAPDyKFoJfNE7HcL3BcbRQpw6uOvQYrD=bEYvgUxjvOaX36o=fA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 12:35 ` Ulf Hansson
2016-03-17 11:29 ` Jon Hunter
[not found] ` <56EA952B.5020900-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-17 13:55 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D84500.1030807@intel.com \
--to=adrian.hunter@intel.com \
--cc=dev@lynxeye.de \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.