From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO Date: Thu, 3 Mar 2016 15:59:45 +0100 Message-ID: <56D85161.6070503@linux.intel.com> References: <1456948331-7300-5-git-send-email-gustavo@padovan.org> <1457015665-7534-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 57B846EA96 for ; Thu, 3 Mar 2016 14:59:49 +0000 (UTC) In-Reply-To: <1457015665-7534-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T3AgMDMtMDMtMTYgb20gMTU6MzQgc2NocmVlZiBHdXN0YXZvIFBhZG92YW46Cj4gRnJvbTogR3Vz dGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgo+Cj4gQ2hhbmdl IFNZTkNfSU9DX0ZJTEVfSU5GTyBiZWhhdmlvdXIgdG8gYXZvaWQgZnV0dXJlIEFQSSBicmVha3Mg YW5kCj4gb3B0aW1pemUgYnVmZmVyCj4KPiBOb3cgbnVtX2ZlbmNlcyBjYW4gYmUgZmlsbGVkIGJ5 IHRoZSBjYWxsZXIgdG8gaW5mb3JtIGhvdyBtYW55IGZlbmNlcyBpdAo+IHdhbnRzIHRvIHJldHJp ZXZlIGZyb20gdGhlIGtlcm5lbC4gSWYgdGhlIG51bV9mZW5jZXMgcGFzc2VkIGlzIGdyZWF0ZXIK PiB0aGFuIHplcm8gaW5mby0+c3luY19mZW5jZV9pbmZvIHNob3VsZCBwb2ludCB0byBhIGJ1ZmZl ciB3aXRoIGVub3VnaCBzcGFjZQo+IHRvIGZpdCBhbGwgZmVuY2VzLgo+Cj4gSG93ZXZlciBpZiBu dW1fZmVuY2VzIHBhc3NlZCB0byB0aGUga2VybmVsIGlzIDAsIHRoZSBrZXJuZWwgd2lsbCByZXBs eQo+IHdpdGggbnVtYmVyIG9mIGZlbmNlcyBvZiB0aGUgc3luY19maWxlLgo+Cj4gU2VuZGluZyBm aXJzdCBhbiBpb2N0bCB3aXRoIG51bV9mZW5jZXMgPSAwIGNhbiBvcHRpbWl6ZSBidWZmZXIgYWxs b2NhdGlvbiwKPiBpbiBhIGZpcnN0IGNhbGwgd2l0aCBudW1fZmVuY2VzID0gMCB1c2Vyc3BhY2Ug d2lsbCByZWNlaXZlIHRoZSBhY3R1YWwKPiBudW1iZXIgb2YgZmVuY2VzIGluIHRoZSBudW1fZmVu Y2VzIGZpbGVkLgo+Cj4gVGhlbiBpdCBjYW4gYWxsb2NhdGUgYSBidWZmZXIgd2l0aCB0aGUgY29y cmVjdCBzaXplIG9uIHN5bmNfZmVuY2VfaW5mbyBhbmQKPiBjYWxsIFNZTkNfSU9DX0ZJTEVfSU5G TyBhZ2FpbiwgYnV0IG5vdyB3aXRoIHRoZSBhY3R1YWwgdmFsdWUgb2YgbnVtX2ZlbmNlcwo+IGlu IHRoZSBzeW5jX2ZpbGUuCj4KPiBBbHNvLCBpbmZvLT5zeW5jX2ZlbmNlX2luZm8gd2FzIGNvbnZl cnRlZCB0byBfX3U2NCBwb2ludGVyIHRvIHByZXZlbnQKPiAzMmJpdCBjb21wYXRpYmlsaXR5IGlz c3Vlcy4KRm9yIHRoaXMgcGF0Y2ggYW5kIDYvNjoKClJldmlld2VkLWJ5OiBNYWFydGVuIExhbmto b3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758054AbcCCO7w (ORCPT ); Thu, 3 Mar 2016 09:59:52 -0500 Received: from mga14.intel.com ([192.55.52.115]:37802 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754675AbcCCO7t (ORCPT ); Thu, 3 Mar 2016 09:59:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,532,1449561600"; d="scan'208";a="916146898" Subject: Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO To: Gustavo Padovan , Greg Kroah-Hartman References: <1456948331-7300-5-git-send-email-gustavo@padovan.org> <1457015665-7534-1-git-send-email-gustavo@padovan.org> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan From: Maarten Lankhorst Message-ID: <56D85161.6070503@linux.intel.com> Date: Thu, 3 Mar 2016 15:59:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1457015665-7534-1-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 03-03-16 om 15:34 schreef Gustavo Padovan: > From: Gustavo Padovan > > Change SYNC_IOC_FILE_INFO behaviour to avoid future API breaks and > optimize buffer > > Now num_fences can be filled by the caller to inform how many fences it > wants to retrieve from the kernel. If the num_fences passed is greater > than zero info->sync_fence_info should point to a buffer with enough space > to fit all fences. > > However if num_fences passed to the kernel is 0, the kernel will reply > with number of fences of the sync_file. > > Sending first an ioctl with num_fences = 0 can optimize buffer allocation, > in a first call with num_fences = 0 userspace will receive the actual > number of fences in the num_fences filed. > > Then it can allocate a buffer with the correct size on sync_fence_info and > call SYNC_IOC_FILE_INFO again, but now with the actual value of num_fences > in the sync_file. > > Also, info->sync_fence_info was converted to __u64 pointer to prevent > 32bit compatibility issues. For this patch and 6/6: Reviewed-by: Maarten Lankhorst