From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg
<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/mlx5: Convert UMR CQ to new CQ API
Date: Thu, 3 Mar 2016 11:26:23 -0500 [thread overview]
Message-ID: <56D865AF.5000507@redhat.com> (raw)
In-Reply-To: <56D7FE93.9020503-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On 03/03/2016 04:06 AM, Sagi Grimberg wrote:
>
>> Thanks for the review Haggai. I noticed I left a stray
>> ib_req_notify_cq in the code, which is harmless but not needed with
>> the new API. Patch with that one line updated below.
>>
>> Doug, can you picks this up for the mlx5 branch?
>
> The patch looks fine to me too,
>
> Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
I took the later version of the patch, but I had to fix it up due to
conflicts with both the rereg_me patchset and the mmkey cleanup
patchset. Please double check this in the mlx5 branch of my github repo
to make sure it's all good.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
next prev parent reply other threads:[~2016-03-03 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 9:39 use the new CQ API in the mlx5 driver Christoph Hellwig
[not found] ` <1456565984-28998-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-27 9:39 ` [PATCH] IB/mlx5: Convert UMR CQ to new CQ API Christoph Hellwig
[not found] ` <1456565984-28998-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-28 11:17 ` Sagi Grimberg
[not found] ` <56D2D731.5060904-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-29 7:23 ` Haggai Eran
[not found] ` <56D3F1EA.9090800-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-03-03 8:38 ` Christoph Hellwig
[not found] ` <20160303083822.GB13828-jcswGhMUV9g@public.gmane.org>
2016-03-03 9:06 ` Sagi Grimberg
[not found] ` <56D7FE93.9020503-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-03-03 16:26 ` Doug Ledford [this message]
[not found] ` <56D865AF.5000507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-04 16:54 ` Christoph Hellwig
[not found] ` <20160304165426.GA29122-jcswGhMUV9g@public.gmane.org>
2016-03-04 16:56 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D865AF.5000507@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.