From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not available
Date: Thu, 3 Mar 2016 09:58:32 -0700 [thread overview]
Message-ID: <56D86D38.7050400@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ2GO9tN1U4+BhTx5bSbC+-m+NnC6EKRjqmpCoNqz-qS3Q@mail.gmail.com>
On 03/02/2016 05:25 PM, Simon Glass wrote:
> Hi Stephen,
>
> On 29 February 2016 at 16:39, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 02/25/2016 09:00 PM, Simon Glass wrote:
>>>
>>> Don't try to run commands when not supported.
>>
>>
>>> diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c
>>
>>
>>> +int board_run_command(const char *cmdline)
>>> +{
>>> + printf("## Commands are disabled. Please enable
>>> CONFIG_CMDLINE.\n");
>>> +
>>> + return 1;
>>> +}
>>> +
>>
>>
>> Isn't this part of patch 5/9?
>
> No - this is the sandbox support. That patch merely declares the
> function in a header. Any board can implement it, and each would do so
> in a separate patch.
OK, but this patch implements the function before there's a prototype
for it in the header. That doesn't seem like the correct order.
next prev parent reply other threads:[~2016-03-03 16:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 4:00 [U-Boot] [PATCH 0/9] Add CONFIG_CMDLINE to allow removal of all commands Simon Glass
2016-02-26 4:00 ` [U-Boot] [PATCH 1/9] cbfs: Update a function to be static Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 2/9] Add an option to enable the command line Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 3/9] arm: x86: Drop command-line code when CONFIG_CMDLINE is disabled Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not available Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-29 23:39 ` Stephen Warren
2016-03-03 0:25 ` Simon Glass
2016-03-03 16:58 ` Stephen Warren [this message]
2016-02-26 4:00 ` [U-Boot] [PATCH 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 6/9] Hang when no command line processing can be performed Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-26 17:31 ` Simon Glass
2016-02-26 17:45 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 7/9] Allow command code to compile to nothing Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-29 23:40 ` Stephen Warren
2016-03-03 0:25 ` Simon Glass
2016-02-26 4:00 ` [U-Boot] [PATCH 8/9] Allow command-line files to be dropped Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-26 17:31 ` Simon Glass
2016-02-26 4:00 ` [U-Boot] [PATCH 9/9] Drop various features when the command line is not available Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-29 23:47 ` Stephen Warren
2016-02-29 23:56 ` Tom Rini
2016-03-03 0:25 ` Simon Glass
2016-03-03 0:58 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D86D38.7050400@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.