From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: vop: fix crtc size in plane check Date: Fri, 04 Mar 2016 09:04:57 +0800 Message-ID: <56D8DF39.8020104@rock-chips.com> References: <1456143779-16208-1-git-send-email-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1456143779-16208-1-git-send-email-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDAy5pyIMjLml6UgMjA6MjIsIEpvaG4gS2VlcGluZyB3cm90ZToKPiBJZiB0aGUg Z2VvbWV0cnkgb2YgYSBjcnRjIGlzIGNoYW5naW5nIGluIGFuIGF0b21pYyB1cGRhdGUgdGhlbiB3 ZSBtdWNoCgpJIHRoaW5rICJ3ZSBtdWNoIHZhbGlkYXRlIiBzaG91bGQgYmUgIndlIG11c3QgdmFs aWRhdGUiLjotKQoKPiB2YWxpZGF0ZSB0aGUgcGxhbmUgc2l6ZSBhZ2FpbnN0IHRoZSBuZXcgc3Rh dGUgb2YgdGhlIGNydGMgYW5kIG5vdCB0aGUKPiBjdXJyZW50IHNpemUsIG90aGVyd2lzZSBpZiB0 aGUgY3J0YyBzaXplIGlzIGluY3JlYXNpbmcgdGhlIHBsYW5lIHdpbGwgYmUKPiBjcm9wcGVkIGF0 IHRoZSBwcmV2aW91cyBzaXplIGFuZCB3aWxsIG5vdCBmaWxsIHRoZSBzY3JlZW4uCj4KPiBTaWdu ZWQtb2ZmLWJ5OiBKb2huIEtlZXBpbmc8am9obkBtZXRhbmF0ZS5jb20+CgotLSAK77ytYXJrIFlh bwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 04 Mar 2016 09:04:57 +0800 Subject: [PATCH] drm/rockchip: vop: fix crtc size in plane check In-Reply-To: <1456143779-16208-1-git-send-email-john@metanate.com> References: <1456143779-16208-1-git-send-email-john@metanate.com> Message-ID: <56D8DF39.8020104@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?02?22? 20:22, John Keeping wrote: > If the geometry of a crtc is changing in an atomic update then we much I think "we much validate" should be "we must validate".:-) > validate the plane size against the new state of the crtc and not the > current size, otherwise if the crtc size is increasing the plane will be > cropped at the previous size and will not fill the screen. > > Signed-off-by: John Keeping -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932883AbcCDBFL (ORCPT ); Thu, 3 Mar 2016 20:05:11 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:52279 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757773AbcCDBFJ (ORCPT ); Thu, 3 Mar 2016 20:05:09 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <57093808bd29d26eb5779f181cebbc58> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56D8DF39.8020104@rock-chips.com> Date: Fri, 04 Mar 2016 09:04:57 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: John Keeping CC: Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: vop: fix crtc size in plane check References: <1456143779-16208-1-git-send-email-john@metanate.com> In-Reply-To: <1456143779-16208-1-git-send-email-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年02月22日 20:22, John Keeping wrote: > If the geometry of a crtc is changing in an atomic update then we much I think "we much validate" should be "we must validate".:-) > validate the plane size against the new state of the crtc and not the > current size, otherwise if the crtc size is increasing the plane will be > cropped at the previous size and will not fill the screen. > > Signed-off-by: John Keeping -- Ｍark Yao