From: Lu Baolu <baolu.lu@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Lee Jones <lee.jones@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] usb: misc: add common code for Intel dual role port mux
Date: Fri, 4 Mar 2016 09:25:33 +0800 [thread overview]
Message-ID: <56D8E40D.20202@linux.intel.com> (raw)
In-Reply-To: <20160303161556.GE3743@kroah.com>
On 03/04/2016 12:15 AM, Greg Kroah-Hartman wrote:
> On Thu, Mar 03, 2016 at 02:37:40PM +0800, Lu Baolu wrote:
>> +#if IS_ENABLED(CONFIG_USB_MUX)
>> +extern int usb_mux_register(struct usb_mux_dev *mux);
>> +extern int usb_mux_unregister(struct device *dev);
>> +extern struct usb_mux_dev *usb_mux_get_dev(struct device *dev);
> This api needs a lot of work, for such a "tiny" api, it's obviously
> pretty incorrect. Please fix it up to be sane...
Sure.
>
>
>
next prev parent reply other threads:[~2016-03-04 1:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 6:37 [PATCH 0/7] usb: add support for Intel dual role port mux Lu Baolu
2016-03-03 6:37 ` [PATCH 1/7] extcon: usb-gpio: add device binding for platform device Lu Baolu
2016-03-03 7:24 ` Chanwoo Choi
2016-03-03 7:35 ` Lu Baolu
2016-03-03 6:37 ` [PATCH 2/7] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu
2016-03-03 7:24 ` Chanwoo Choi
2016-03-03 7:35 ` Lu Baolu
2016-03-03 6:37 ` [PATCH 3/7] usb: misc: add common code for Intel dual role port mux Lu Baolu
2016-03-03 16:10 ` Greg Kroah-Hartman
2016-03-04 1:11 ` Lu Baolu
2016-03-03 16:15 ` Greg Kroah-Hartman
2016-03-04 1:25 ` Lu Baolu [this message]
2016-03-03 6:37 ` [PATCH 4/7] usb: misc: add driver for Intel gpio controlled " Lu Baolu
2016-03-03 8:16 ` kbuild test robot
2016-03-03 8:16 ` [PATCH] usb: misc: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-03-03 6:37 ` [PATCH 5/7] usb: misc: add driver for Intel drcfg controlled port mux Lu Baolu
2016-03-03 15:20 ` kbuild test robot
2016-03-03 16:12 ` Greg Kroah-Hartman
2016-03-04 1:41 ` Lu Baolu
2016-03-03 16:14 ` Greg Kroah-Hartman
2016-03-04 1:38 ` Lu Baolu
2016-03-04 1:44 ` Greg Kroah-Hartman
2016-03-04 1:58 ` Lu Baolu
2016-03-03 6:37 ` [PATCH 6/7] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu
2016-03-03 6:37 ` [PATCH 7/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu
2016-03-03 8:16 ` [PATCH] mfd: intel_vuport: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-03-03 8:16 ` [PATCH 7/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver kbuild test robot
2016-03-03 11:35 ` kbuild test robot
2016-03-03 17:26 ` kbuild test robot
2016-03-03 19:57 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8E40D.20202@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=balbi@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.