From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2] nfit: Continue init even if ARS commands are unimplemented Date: Fri, 4 Mar 2016 11:28:42 +0800 Message-ID: <56D900EA.2060802@linux.intel.com> References: <1457044781-15443-1-git-send-email-vishal.l.verma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:4983 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755790AbcCDD27 (ORCPT ); Thu, 3 Mar 2016 22:28:59 -0500 In-Reply-To: <1457044781-15443-1-git-send-email-vishal.l.verma@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Vishal Verma , linux-nvdimm@lists.01.org Cc: linux-acpi@vger.kernel.org, Dan Williams , "Zhang, Haozhong" CCed: Haozhong. On 03/04/2016 06:39 AM, Vishal Verma wrote: > If firmware doesn't implement any of the ARS commands, take that to > mean that ARS is unsupported, and continue to initialize regions without > bad block lists. We cannot make the assumption that ARS commands will be > unconditionally supported on all NVDIMMs. > > Cc: Dan Williams > Reported-by: Xiao Guangrong Thank you for the fix, Vishal! it looks good to me. However, It is haozhong's credit as he is the one reported the bug not me. :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ml01.01.org (Postfix) with ESMTP id 26DD91A1E46 for ; Thu, 3 Mar 2016 19:29:08 -0800 (PST) Subject: Re: [PATCH v2] nfit: Continue init even if ARS commands are unimplemented References: <1457044781-15443-1-git-send-email-vishal.l.verma@intel.com> From: Xiao Guangrong Message-ID: <56D900EA.2060802@linux.intel.com> Date: Fri, 4 Mar 2016 11:28:42 +0800 MIME-Version: 1.0 In-Reply-To: <1457044781-15443-1-git-send-email-vishal.l.verma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Vishal Verma , linux-nvdimm@lists.01.org Cc: linux-acpi@vger.kernel.org List-ID: CCed: Haozhong. On 03/04/2016 06:39 AM, Vishal Verma wrote: > If firmware doesn't implement any of the ARS commands, take that to > mean that ARS is unsupported, and continue to initialize regions without > bad block lists. We cannot make the assumption that ARS commands will be > unconditionally supported on all NVDIMMs. > > Cc: Dan Williams > Reported-by: Xiao Guangrong Thank you for the fix, Vishal! it looks good to me. However, It is haozhong's credit as he is the one reported the bug not me. :) _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm